Typo in llvm_function_reference

Started by Rushabh Lathiaalmost 8 years ago2 messageshackers
Jump to latest
#1Rushabh Lathia
rushabh.lathia@gmail.com

Hi,

There is multiple return statement in llvm_function_reference
and that's definitely looks typo. Here is the patch to fix the
same.

Thanks,
Rushabh Lathia
www.EnterpriseDB.com

Attachments:

typo_llvmjit.patchtext/x-patch; charset=US-ASCII; name=typo_llvmjit.patchDownload+0-1
#2Andres Freund
andres@anarazel.de
In reply to: Rushabh Lathia (#1)
Re: Typo in llvm_function_reference

Hi,

On 2018-06-27 10:46:35 +0530, Rushabh Lathia wrote:

There is multiple return statement in llvm_function_reference
and that's definitely looks typo. Here is the patch to fix the
same.

diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
index daae964..5d0cdab 100644
--- a/src/backend/jit/llvm/llvmjit.c
+++ b/src/backend/jit/llvm/llvmjit.c
@@ -394,7 +394,6 @@ llvm_function_reference(LLVMJitContext *context,
LLVMSetGlobalConstant(v_fn, true);

return LLVMBuildLoad(builder, v_fn, "");
- return v_fn;
}

/* check if function already has been added */

Thanks! Pushed.

Greetings,

Andres Freund