Dec 2024

1 commit
Improve comment about dropped entries in pgstat.c
9 Dec 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.3REL_16_STABLE16.7REL_15_STABLE15.11
LLM analysis, 99% suremodified before commitlight changesfrom patchset #3332 of 2 reviewers saw the final version

Rewords the pgstat_write_statsfile comment from #333, retaining the same assertion and dropped-entry skip.

  • Anton A. Melnikovsaw the final versionLLM analysis, 99% sureExplicitly approved the detailed shutdown comment in #334 before it was committed.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Mar - Apr 2022

32 commits
pgstat: set timestamps of fixed-numbered stats after a crash.
15 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The crash-reset timestamp fix was proposed inline in #293 after reports in #291 and #292; no attached patch implements this change.

  • David G. Johnstonsaw the final versionLLM analysis, 99% sureReported and narrowed the incorrect reset timestamp after crash recovery in #292.
  • Michael Paquiersaw the final versionLLM analysis, 99% sureReproduced the crash-reset timestamp problem before the inline fix was committed #294.
pgstat: Update docs to match the shared memory stats reality.
8 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2524 of 4 reviewers saw the final version

Extracts the documentation component of #252, with wording and standby/crash-restart clarifications discussed in #280 and #282.

  • Thomas Munrosaw the final versiontrailerReviewed documentation wording in #231; later documentation changes were light.
  • Justin Pryzbysaw the final versiontrailerProposed the snapshot-versus-cache wording adopted after #268.
  • David G. Johnstonsaw the final versiontrailerReviewed statistics semantics and restart documentation in #234 and #282.
  • Lukas Fittlsaw the final versiontrailerSupplied documentation corrections and endorsed the clarified cache wording in #266 and #269.
pgstat: add/extend tests for resetting various kinds of stats.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #252

Combines the reset, subscription, and replication-slot test components of #252, with test polishing and helper-name updates.

pgstat: test stats interactions with physical replication.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #252

Extracts the physical-replication statistics tests from #252, streamlining output and updating helper names while retaining drop/restart coverage.

Add minimal tests for recovery conflict handling.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #252

Extracts the recovery-conflict TAP test from #252, substantially simplifying its synchronization/helpers and reducing it from roughly 378 to 296 lines.

pgstat: add tests for handling of restarts, including crashes.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

Extracts the restart/crash/corrupt-file TAP tests from #252, simplifying the file path and polishing configuration and assertions.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 99% sureSuggested the simpler statistics-file path adopted in the restart test in #260.
pgstat: add tests for transaction behaviour, 2PC, function stats.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #252

Extracts the transaction, two-phase commit, and function-statistics tests from #252, with helper renames and small test-order adjustments.

pgstat: add pg_stat_have_stats() test helper.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2523 of 3 reviewers saw the final version

Extracts the existence-test helper from #252, renaming it pg_stat_have_stats and adding the catalog-version bump.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 99% sureReviewed the statistics-existence helper in #260.
  • Thomas Munrosaw the final versionLLM analysis, 95% sureQuestioned the existence-helper name in #231, leading to the final pg_stat_have_stats naming.
  • Andres Freundsaw the final versioncommittercommitted the patch
pgstat: add pg_stat_force_next_flush(), use it to simplify tests.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

Combines the pg_stat_force_next_flush helper and test-simplification components of #252; their substantive changes match the posted patches.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 98% sureChecked the flush-helper attributes and test simplification in #260.
pgstat: store statistics in shared memory.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: shared memory stats: high level design decisions: consistency, droppingAlso in: Naming of the different stats systems / "stats collector"
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #2522 of 7 reviewers saw the final version

Lands the main shared-memory component of #252, with subsequent reset-API generalization, localized fixes, naming changes, and comment polishing; separate prerequisites, tests, and documentation land independently.

  • Andres Freundsaw the final versiontrailerDrove repeated architecture reviews, rewrote the implementation, and reviewed the final version as its committer #199 #252.
  • Thomas Munrosaw an earlier versiontrailerReviewed dshash locking, reference lifetimes, and snapshot error paths in #104 and #231, before moderate final changes.
  • Justin Pryzbysaw an earlier versiontrailerAndres acknowledges incorporated wording feedback in #232 and #243, before later implementation changes; the direct in-thread review is documentation-focused.
  • David G. Johnstonsaw the final versiontrailerReviewed architecture and the final series, then discussed the final reset-API design in #254 and #273.
  • Tomas Vondrasaw an earlier versiontrailerRan Valgrind and performance tests and supplied an EXEC_BACKEND fix before substantial redesign #27 #38 #43.
  • Arthur Zakirovsaw an earlier versiontrailerFound an autovacuum lifetime bug and archiver/TAP omissions in #60 and #63, before later redesigns.
  • Antonin Houskasaw an earlier versiontrailerReviewed locking, collector removal, signal-handler safety, and scan races in #20 and #26, before substantial redesign.
pgstat: remove stats_temp_directory.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: Higher level questions around shared memory stats
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

Extracts stats_temp_directory removal from #252, preserving pg_stat_tmp for extensions; differences concern temporary comments and rebasing.

  • Kyotaro Horiguchisaw the final versiontrailerReviewed this component in #260, with only light edits before landing.
pgstat: rename STATS_COLLECTOR GUC group to STATS_CUMULATIVE.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

The STATS_COLLECTOR to STATS_CUMULATIVE rename matches its component of #252 without substantive edits.

  • Kyotaro Horiguchisaw the final versiontrailerReviewed this component in #260, with only light edits before landing.
pgstat: move pgstat.c to utils/activity.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

The Makefile changes and move of pgstat.c into utils/activity match the corresponding component of #252.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 99% sureApproved the pgstat.c relocation in #260.
pgstat: revise replication slot API in preparation for shared memory stats.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #2520 of 1 reviewer saw the final version

Extracts the replication-slot API component of #252, additionally converting the drop API, checking slot bounds, and adjusting the old collector vacuum path.

  • Kyotaro Horiguchino review foundtrailerExplicitly skipped the replication-slot API component in #260; no other review of this component is established in the thread.
pgstat: scaffolding for transactional stats creation / drop.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #2520 of 2 reviewers saw the final version

Extracts transactional statistics creation/drop scaffolding from #252, fixing dropped-item allocation size, freeing temporary arrays, and adjusting component boundaries.

  • Thomas Munrosaw an earlier versiontrailerReviewed transactional-drop scaffolding and its explanation in #231, before later allocation and cleanup fixes.
  • Kyotaro Horiguchisaw an earlier versiontrailerReviewed the posted component in #260, before subsequent allocation and cleanup changes.
pgstat: prepare APIs used by pgstatfuncs for shared memory stats.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #2520 of 1 reviewer saw the final version

Reworks the API-preparation component of #252 into generic pgstat_reset and pgstat_reset_of_kind helpers, following #270 through #273.

  • Kyotaro Horiguchisaw an earlier versiontrailerReviewed the posted component without objections in #260, before subsequent reset-API generalization.
pgstat: introduce PgStat_Kind enum.
7 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

Extracts PgStat_Kind from #252, adding an explicit INVALID value and FIRST_VALID naming without changing valid kind numbers.

  • Kyotaro Horiguchisaw the final versiontrailerReviewed the enum and raised its count/invalid-value issue in #260, followed by light enum-definition edits.
pgstat: add pgstat_copy_relation_stats().
6 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

The pgstat_copy_relation_stats changes match the corresponding component of #252.

  • Kyotaro Horiguchisaw the final versiontrailerReviewed this component in #260, and its posted changes match the commit.
pgstat: rename some pgstat_send_* functions to pgstat_report_*.
6 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

The pgstat_send_* to pgstat_report_* renames match the corresponding component of #252.

  • Kyotaro Horiguchisaw the final versiontrailerChecked the renames and pointed out remaining Valgrind references in #260.
pgstat: stats collector references in comments.
6 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: Naming of the different stats systems / "stats collector"
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2523 of 3 reviewers saw the final version

Extracts the collector-comment cleanup from #252, with several final wording corrections.

  • Justin Pryzbysaw the final versiontrailerHis wording review is credited in the patch and acknowledged with the incorporated reviews in #235 and #243.
  • Thomas Munrosaw the final versiontrailerReviewed the preparatory comment changes in #231; subsequent edits were light.
  • Kyotaro Horiguchisaw the final versiontrailerChecked that collector terminology had been removed across the series in #260.
pgstat: move transactional code into pgstat_xact.c.
6 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

Extracts the pgstat_xact.c code movement from #252, additionally grouping its declarations in pgstat.h.

  • Thomas Munrosaw the final versiontrailerReviewed the transactional-code movement in #231; subsequent changes were declaration placement and formatting.
dsm: allow use in single user mode.
6 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2521 of 1 reviewer saw the final version

Extracts single-user DSM support from #252, with comment and indentation changes only.

  • Thomas Munrosaw the final versiontrailerApproved the single-user DSM changes in #231; later edits were light.
dshash: revise sequential scan support.
4 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2301 of 1 reviewer saw the final version

The dshash sequential-scan revision matches its component of #230 apart from a comment edit and rebase differences.

  • Thomas Munrosaw the final versiontrailerChecked the initial partition-locking logic and approved the scan changes in #231.
pgstat: remove some superflous comments from pgstat.h.
4 Apr 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2301 of 1 reviewer saw the final version

The pgstat.h comment removals exactly match their component of #230.

  • Thomas Munrosaw the final versiontrailerReviewed the preparatory cleanups in #231, and this component landed unchanged.
pgstat: reorder pgstat.[ch] contents.
21 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2151 of 1 reviewer saw the final version

Extracts the pgstat.[ch] reordering component of #215, with additional declaration and function-placement polishing.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 82% sureReviewed the pgstat file reordering in #201; subsequent changes to this component were movement-only cleanup.
pgstat: split different types of stats into separate files.
21 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2110 of 1 reviewer saw the final version

Extracts the per-statistics-type file split from #211, polishing headers and code placement and renaming pgstat_checkpoint.c to pgstat_checkpointer.c.

  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 96% sureReviewed statistics file separation in #201; the later split into individual fixed-statistics files substantially extended that version.
pgstat: separate "xact level" handling out of relation specific functions.
21 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2111 of 1 reviewer saw the final version

The transaction-level cleanup component of #211 matches the committed changes.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 96% sureReviewed the transaction-level helpers in #201; subsequent changes to this component were light.
pgstat: introduce pgstat_relation_should_count().
21 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #211

The pgstat_relation_should_count component of #211 matches the committed changes.

pgstat: rename pgstat_initstats() to pgstat_relation_init().
21 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #211

Takes only the pgstat_initstats to pgstat_relation_init rename from the init/association component of #211; lazy association remains for the later main patch.

pgstat: run pgindent on pgstat.c/h.
19 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #211

The pgindent-only component of #211 matches the committed changes.

pgstat: split relation, database handling out of pgstat_report_stat().
19 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #211

The relation/database-reporting extraction component of #211 matches the committed changes.

pgstat: split out WAL handling from pgstat_{initialize,report_stat}.
19 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #211

The WAL-reporting extraction component of #211 matches the committed changes.

Sep 2021

2 commits
pgstat: Prepare to use mechanism for truncated rels also for droppped rels.
20 Sep 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #199

The truncate/drop preparation component of #199 matches the committed changes.

pgstat: Split out relation stats handling from AtEO[Sub]Xact_PgStat() etc.
20 Sep 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1991 of 1 reviewer saw the final version

Extracts the relation transaction-handling split from #199, with comment and PostPrepare code-placement adjustments.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 96% sureReviewed the relation transaction-handling split in #201; subsequent changes to this component were light.

Aug 2021

5 commits
pgstat: Schedule per-backend pgstat shutdown via before_shmem_exit().
7 Aug 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: straightening out backend process startup (not this thread)Also in: Dividing line between before_shmem_exit and on_shmem_exit?
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #199

Extracts the on_shmem_exit to before_shmem_exit substitution for pgstat_shutdown_hook in src/backend/postmaster/pgstat.c already present in #199; the commit explicitly says it was split from the shared-memory statistics patch. I disagree with thread #44627's from_discussion attribution because its attachments lack this change, while that thread and thread #44631 supplied prerequisite startup and shutdown-ordering discussion.

Schedule ShutdownXLOG() in single user mode using before_shmem_exit().
7 Aug 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: Dividing line between before_shmem_exit and on_shmem_exit?
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #199

Extracts the single-user ShutdownXLOG callback component of #199, expanding only its explanatory comment.

Make parallel worker shutdown complete entirely via before_shmem_exit().
7 Aug 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: Dividing line between before_shmem_exit and on_shmem_exit?
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #199

Extracts the parallel-worker shutdown/DSM-detach component of #199, with explanatory comments and cast formatting.

pgstat: Bring up pgstat in BaseInit() to fix uninitialized use of pgstat by AV.
7 Aug 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: straightening out backend process startup (not this thread)
LLM analysis, 96% surepart of a posted patchsetmoderate changesfrom patchset #199

Extracts the initialization prerequisite from #199, replacing scattered early pgstat_initialize calls with initialization in BaseInit in src/backend/utils/init/postinit.c and adding lifecycle assertions in src/backend/postmaster/pgstat.c. The final implementation uses startup restructuring from thread #44627, but I disagree with that thread's from_discussion attribution: its verdict confirms neither attachment contains this change, whereas this thread supplied the initialization patch.

pgstat: split reporting/fetching of bgwriter and checkpointer stats.
5 Aug 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1991 of 1 reviewer saw the final version

Extracts the bgwriter/checkpointer split from #199, with minor file-format and surrounding-code adjustments.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 96% sureReviewed the bgwriter/checkpointer split in #201; subsequent changes to this component were light.

Apr 2021

2 commits
Split backend status and progress related functionality out of pgstat.c.
3 Apr 2021Andres Freundmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #1790 of 1 reviewer saw the final version

Extracts the backend-status/progress component of #179, revising initialization and snapshot/context interfaces before landing.

  • Robert Haassaw an earlier versiontrailerReviewed the initial split in #182; the commit explicitly credits an earlier review before initialization and snapshot-interface revisions.
Split wait event related code from pgstat.[ch] into wait_event.[ch].
3 Apr 2021Andres Freundmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1791 of 1 reviewer saw the final version

Extracts the wait-event component of #179, with header/comment polishing and adaptation to newly added waits.

  • Robert Haassaw the final versiontrailerReviewed the extraction and header organization in #182; the wait-event component subsequently received light edits.

Mar 2021

1 commit
Make archiver process an auxiliary process.
15 Mar 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #1701 of 6 reviewers saw the final version

The standalone archiver patch in #170 matches the implementation, with only function placement and formatting adjustments.

  • Andres Freundsaw an earlier versiontrailerSuggested process-number based archiver wakeups in #156, before that implementation and restart handling were revised.
  • Álvaro Herrerasaw an earlier versiontrailerReviewed archiver error behavior and found assertion-only latch assignments before later wakeup redesign #89 #110.
  • Julien Rouhaudsaw an earlier versiontrailerIdentified archive-command signal and exit-code cases in #98, before later archiver revisions.
  • Tomas Vondrasaw an earlier versiontrailerReviewed the auxiliary-archiver and buildable-series changes in #38 and #40, well before final revisions.
  • Arthur Zakirovsaw an earlier versiontrailerIdentified missing archiver backend-type and TAP adjustments in #63, before later implementation changes.
  • Fujii Masaosaw the final versiontrailerReviewed restart and latch safety, posted the polished patch, and committed it #154 #170.

Credits across 43 commits

Author
Andres Freund5 LLM39
Melanie Plageman7
Kyotaro Horiguchi6
Bertrand Drouvot1
Reviewer
Kyotaro Horiguchi9
Thomas Munro8
Andres Freundcommitter3
Justin Pryzby3
Arthur Zakirov2
David G. Johnston2
Robert Haas2
Tomas Vondra2
Alvaro Herrera1
Antonin Houska1
Fujii Masao1
Julien Rouhaud1
Lukas Fittl1
Michael Paquiercommitter1
Reported by
David G. Johnston1
Committer
Andres Freund41
Fujii Masao1
Michael Paquier1

N LLM means N of the credits come from LLM analysis, not from commit trailers.