Comment refers to non existent function IncreaseRestartDecodingForSlot

Started by Dave Crameralmost 8 years ago3 messageshackers
Jump to latest
#1Dave Cramer
pg@fastcrypt.com

While trying to figure out this code I found

https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913

What function should it be referring to ?

Thanks,

Dave Cramer

In reply to: Dave Cramer (#1)
Re: Comment refers to non existent function IncreaseRestartDecodingForSlot

2018-06-29 15:55 GMT-03:00 Dave Cramer <davecramer@gmail.com>:

While trying to figure out this code I found

https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913

What function should it be referring to ?

LogicalIncreaseXminForSlot (it is a few lines above). It has been like
that since logical decoding was introduced. The trivial patch fixes
it.

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachments:

typo.patchtext/x-patch; charset=US-ASCII; name=typo.patchDownload+1-1
#3Michael Paquier
michael@paquier.xyz
In reply to: Euler Taveira de Oliveira (#2)
Re: Comment refers to non existent function IncreaseRestartDecodingForSlot

On Fri, Jun 29, 2018 at 05:34:21PM -0300, Euler Taveira wrote:

LogicalIncreaseXminForSlot (it is a few lines above). It has been like
that since logical decoding was introduced. The trivial patch fixes
it.

That looks right to me. Pushed.
--
Michael