pgbench - remove double declaration of hash functions
Started by Fabien COELHOover 7 years ago2 messages
I noticed that hash functions appear twice in the list of pgbench
functions, although once is enough. The code is functional nevertheless,
but it looks silly. This was added by "e51a04840a1" back in March, so
should be removed from 11 and 12dev.
--
Fabien.
Attachments:
pgbench-fix-func-1.patchtext/plain; name=pgbench-fix-func-1.patchDownload
diff --git a/src/bin/pgbench/exprparse.y b/src/bin/pgbench/exprparse.y
index 8447e14d14..66288632d1 100644
--- a/src/bin/pgbench/exprparse.y
+++ b/src/bin/pgbench/exprparse.y
@@ -366,15 +366,6 @@ static const struct
{
"hash_fnv1a", PGBENCH_NARGS_HASH, PGBENCH_HASH_FNV1A
},
- {
- "hash", PGBENCH_NARGS_HASH, PGBENCH_HASH_MURMUR2
- },
- {
- "hash_murmur2", PGBENCH_NARGS_HASH, PGBENCH_HASH_MURMUR2
- },
- {
- "hash_fnv1a", PGBENCH_NARGS_HASH, PGBENCH_HASH_FNV1A
- },
/* keep as last array element */
{
NULL, 0, 0
Re: pgbench - remove double declaration of hash functions
On Sun, Jul 22, 2018 at 7:14 PM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
I noticed that hash functions appear twice in the list of pgbench functions,
although once is enough. The code is functional nevertheless, but it looks
silly. This was added by "e51a04840a1" back in March, so should be removed
from 11 and 12dev.
Good catch. Committed and back-patched.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company