Jul - Aug 2021

4 commits
Add prepare API support for streaming transactions in logical replication.
4 Aug 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: logical decoding of two-phase transactions (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #4173 of 3 reviewers saw the final version

The complete committed diff matches #417, enabling streaming with two_phase across pgoutput, proto.c, worker.c, documentation, and tests. Amit forwarded work explicitly credited to Peter Smith and Ajin Cherian.

  • Vignesh Csaw the final versiontrailerReviewed successive streaming patches and reported successful tests and documentation builds for #417 in #419.
  • Amit Kapilasaw the final versiontrailerRequested shared helpers and cleanup in #393 and #406, posted #417, and reviewed the committed version as committer.
  • Greg Nancarrowsaw the final versiontrailerReviewed protocol wording and worker/test comments in #401 against #398, followed only by behavior-preserving interface cleanup and test/documentation refinements.
Fix test failure in 021_twophase.pl.
2 Aug 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #4043 of 3 reviewers saw the final version

Both added waits in src/test/subscription/t/021_twophase.pl exactly match Ajin's attached fix #404 for checking two subscriptions after waiting for only one.

  • Amit Kapilasaw the final versiontrailerDiagnosed the missing wait in #403, approved #404 in #405, and committed it.
  • Vignesh Csaw the final versiontrailerReported that the fix #404 looked good in #407.
  • Peter Smithsaw the final versiontrailerApplied #404 and reported successful TAP tests in #408.
Refactor to make common functions in proto.c and worker.c.
29 Jul 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #3961 of 1 reviewer saw the final version

Commits the helper-refactoring component of #396, leaving streaming support pending. As explained in #397, Amit moves GID construction into apply_handle_prepare_internal, removes a redundant return value, and edits comments.

  • Amit Kapilasaw the final versiontrailerRequested helper extraction in #393, reviewed and adjusted #396 in #397, and committed the result.
Fix potential buffer overruns in proto.c.
20 Jul 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #3881 of 1 reviewer saw the final version

The four strcpy-to-strlcpy replacements using destination sizeof in src/backend/replication/logical/proto.c exactly match #388.

  • Amit Kapilasaw the final versiontrailerRequested sizeof bounds for #385 in #387, approved #388 in #389, and committed it.

Feb 2021

1 commit
Fix an oversight in ReorderBufferFinishPrepared.
23 Feb 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Markus Wanner identifies the erroneous create=true argument in ReorderBufferFinishPrepared and proposes false inline in #196. Amit agrees in #197 and announces the fix in #198; no matching attachment exists.

  • Markus Wannersaw the final versionLLM analysis, 100% sureReported the unnecessary ReorderBufferTXN creation and proposed the exact correction in #196, which the commit credits as Reported-by.

Dec 2020 - Jan 2021

4 commits
Fix typos in decode.c and logical.c.
6 Jan 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Fixes the two existing-code comment errors reported inline by Ajin in #166: extra wording in decode.c and stream_abort_cb instead of stream_commit_cb in logical.c. The push is confirmed in #181, without an attached patch.

  • Ajin Cheriansaw the final versionLLM analysis, 100% sureIdentified both exact comment errors in #166, and the commit explicitly credits his report.
Test decoding of two-phase transactions during the build of a consistent snapshot.
5 Jan 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: logical decoding of two-phase transactions (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1791 of 1 reviewer saw the final version

Matches the isolation test in #179 except for expanded explanatory comments in contrib/test_decoding/specs/twophase_snapshot.spec. Amit explicitly reports minor wordsmithing in #180.

  • Amit Kapilasaw the final versiontrailerReviewed the snapshot test in #178, requested simpler steps and clearer explanations, and committed the revised #179 with wordsmithing.
Allow decoding at prepare time in ReorderBuffer.
4 Jan 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: logical decoding of two-phase transactions (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1741 of 5 reviewers saw the final version

Commits the first component of #174, covering ReorderBuffer prepare-time decoding, tests, and documentation, with only wording and indentation changes confirmed in #177. Sender Amit is a credited coauthor alongside Ajin Cherian.

  • Amit Kapilasaw the final versiontrailerReworked cleanup, snapshot-boundary handling, and filtering across the series, posted #174, and reviewed the final code as committer.
  • Peter Smithsaw an earlier versiontrailerReviewed and tested earlier decoding versions and exposed tablesync behavior in #113, before substantial snapshot-boundary and restart changes.
  • Sawada Masahikosaw an earlier versiontrailerReported timestamp and subscription failures and examined duplicate-prepare handling in #152, before further rollback-metadata and filtering revisions.
  • Arseny Shersaw an earlier versiontrailerIdentified snapshot-boundary data loss and restart concerns in #5 and #9, long before the eventual implementation.
  • Dilip Kumarsaw an earlier versiontrailerReviewed invalidation ordering, prepared-transaction checks, and shared locking in #21 and #38, before subsequent decoding rework.
Extend the output plugin API to allow decoding of prepared xacts.
30 Dec 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: logical decoding of two-phase transactions (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1681 of 4 reviewers saw the final version

Commits the first component of #168: six output-plugin callbacks, wrappers, test_decoding support, and documentation. Comparison shows only cosmetic callback-comment wrapping beyond rebase/hunk presentation; the landing is announced in #173.

  • Amit Kapilasaw the final versiontrailerRevised callback contracts and documentation, declared the API ready in #169, and reviewed the committed version as committer.
  • Peter Smithsaw an earlier versiontrailerReviewed callback naming, behavior, assertions, and tests in #46 and subsequent reviews before begin-prepare and rollback API changes.
  • Sawada Masahikosaw an earlier versiontrailerTested earlier versions and reviewed duplicate-prepare semantics in #152, before prepare metadata was added to rollback callbacks.
  • Dilip Kumarsaw an earlier versiontrailerReviewed earlier prepared-decoding behavior in #21 and #38, before substantial callback-contract revisions.

Credits across 9 commits

Author
Ajin Cherian5
Peter Smith3
Amit Kapila based on previous work by Nikhil Sontakke2
Stas Kelvich2
Reviewer
Amit Kapila7
Peter Smith3
Dilip Kumar2
Masahiko Sawada2
vignesh C2
Arseny Sher1
Greg Nancarrow1
Tested by
osumi.takamichi@fujitsu.com1
tanghy.fnst@fujitsu.com1
Reported by
as per buildfarm1
Markus Wanner1
Michael Paquier1
Tom Lane as per coverity1
Committer
Amit Kapila9