Feb - Mar 2019

3 commits
Allow ATTACH PARTITION with only ShareUpdateExclusiveLock.
7 Mar 2019Robert Haasmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #920 of 2 reviewers saw the final version

Combines all four patches from #92: catalog fallback, PartitionDirectory lifetime management, runtime-pruning remapping, and reduced ATTACH locking. The added and removed code lines match the submission; the additional change updates doc/src/sgml/ddl.sgml to distinguish the partition's ACCESS EXCLUSIVE lock from the parent's SHARE UPDATE EXCLUSIVE lock.

  • Andres Freundsaw an earlier versionLLM analysis, 91% sureAfter #1, identified invalidation freeing descriptors still referenced by running code and proposed delayed reclamation in #6, prompting #7 before substantial architectural changes.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 100% sureIdentified the planner/executor pruning-index mismatch in #64 and examined parallel-directory consistency in #81; 898e5e3290 explicitly credits his review, but substantive correctness changes followed.
Change lock acquisition order in expand_inherited_rtentry.
26 Feb 2019Robert Haasmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #801 of 1 reviewer saw the final version

Extracts the optimizer/util/inherit.c locking changes from the third patch in #80, preserving find_all_inheritors for ordinary inheritance and locking partitions during recursive expansion. The selected changes match, with PartitionDirectory initialization and lookup hunks deferred; #90 confirms this separate landing.

  • David Rowleysaw the final versionLLM analysis, 96% sureExamined the proposed partition-lock ordering in #69 and argued that PartitionDesc order made an added OID sort unnecessary, a conclusion Robert accepted in #71 before extracting the substantially unchanged locking code.
Move code for managing PartitionDescs into a new file, partdesc.c
21 Feb 2019Robert Haasmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #80

Lands the first patch of #80, moving descriptor construction, comparison, and default-partition lookup into partitioning/partdesc.c and partdesc.h. Differences are limited to rebase context and omitting an unnecessary partdesc.h include in pg_constraint.c; #88 announces the extraction.

Credits across 3 commits

Author
Robert HaasLLM3
Committer
Robert Haas3

N LLM means N of the credits come from LLM analysis, not from commit trailers.