unused/redundant foreign key code
I found some unused and some redundant code in ri_triggers.c that was
left around by some previous changes that aimed to optimize away certain
trigger invocations. See attached patches.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
0001-Remove-dead-foreign-key-optimization-code.patchtext/plain; charset=UTF-8; name=0001-Remove-dead-foreign-key-optimization-code.patch; x-mac-creator=0; x-mac-type=0Download+0-52
0002-Apply-RI-trigger-skipping-tests-also-for-DELETE.patchtext/plain; charset=UTF-8; name=0002-Apply-RI-trigger-skipping-tests-also-for-DELETE.patch; x-mac-creator=0; x-mac-type=0Download+6-104
On 8 Aug 2018, at 21:34, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
I found some unused and some redundant code in ri_triggers.c that was
left around by some previous changes that aimed to optimize away certain
trigger invocations. See attached patches.
Both of these patches apply cleanly with minimal offsets, build without
warnings and make check passes.
From reading code and testing, I concur with your findings that this is indeed
dead code.
+1 on this cleanup, I’m marking this as Ready for Committer.
cheers ./daniel
On 09/11/2018 21:37, Daniel Gustafsson wrote:
On 8 Aug 2018, at 21:34, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
I found some unused and some redundant code in ri_triggers.c that was
left around by some previous changes that aimed to optimize away certain
trigger invocations. See attached patches.Both of these patches apply cleanly with minimal offsets, build without
warnings and make check passes.From reading code and testing, I concur with your findings that this is indeed
dead code.+1 on this cleanup, I’m marking this as Ready for Committer.
Committed, thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services