unused/redundant foreign key code
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t39167psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 05:25 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t39167_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t39167_1 && git checkout t39167_1Patchset v1 (message #1) is on t39167_1
I found some unused and some redundant code in ri_triggers.c that was
left around by some previous changes that aimed to optimize away certain
trigger invocations. See attached patches.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
t39167_10001-Remove-dead-foreign-key-optimization-code.patchtext/plain; charset=UTF-8; name=0001-Remove-dead-foreign-key-optimization-code.patch; x-mac-creator=0; x-mac-type=0Download+0-52
0002-Apply-RI-trigger-skipping-tests-also-for-DELETE.patchtext/plain; charset=UTF-8; name=0002-Apply-RI-trigger-skipping-tests-also-for-DELETE.patch; x-mac-creator=0; x-mac-type=0Download+6-104
On 8 Aug 2018, at 21:34, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
I found some unused and some redundant code in ri_triggers.c that was
left around by some previous changes that aimed to optimize away certain
trigger invocations. See attached patches.
Both of these patches apply cleanly with minimal offsets, build without
warnings and make check passes.
From reading code and testing, I concur with your findings that this is indeed
dead code.
+1 on this cleanup, I’m marking this as Ready for Committer.
cheers ./daniel
On 09/11/2018 21:37, Daniel Gustafsson wrote:
On 8 Aug 2018, at 21:34, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
I found some unused and some redundant code in ri_triggers.c that was
left around by some previous changes that aimed to optimize away certain
trigger invocations. See attached patches.Both of these patches apply cleanly with minimal offsets, build without
warnings and make check passes.From reading code and testing, I concur with your findings that this is indeed
dead code.+1 on this cleanup, I’m marking this as Ready for Committer.
Committed, thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services