A dubious message related to SP-GiST compress method.
Started by Kyotaro HORIGUCHIover 7 years ago1 messages
I ran across the followin gcode in spgutils.c.
if (OidIsValid(cache->config.leafType) &&
cache->config.leafType != atttype)
{
if (!OidIsValid(index_getprocid(index, 1, SPGIST_COMPRESS_PROC)))
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("compress method must not defined when leaf type is different from input type")));
fillTypeDesc(&cache->attLeafType, cache->config.leafType);
IIUC the fourth line looks inconsistent with the message in 7th
line. Compress methos is required in the case. Isn't "must not
defined" a typo of "must be defined"?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
spguilts_msg.patchtext/x-patch; charset=us-asciiDownload
diff --git a/src/backend/access/spgist/spgutils.c b/src/backend/access/spgist/spgutils.c
index 4a9b5da268..6d59b316ae 100644
--- a/src/backend/access/spgist/spgutils.c
+++ b/src/backend/access/spgist/spgutils.c
@@ -133,7 +133,7 @@ spgGetCache(Relation index)
if (!OidIsValid(index_getprocid(index, 1, SPGIST_COMPRESS_PROC)))
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
- errmsg("compress method must not defined when leaf type is different from input type")));
+ errmsg("compress method must be defined when leaf type is different from input type")));
fillTypeDesc(&cache->attLeafType, cache->config.leafType);
}