Jan 2020

4 commits
Add --parallel option to vacuumdb command.
29 Jan 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #4052 of 2 reviewers saw the final version

Applying #405 to the commit parent reproduces vacuumdb.c, its TAP tests, and vacuumdb.sgml byte-for-byte. Amit forwards Sawada's implementation with the already-posted revisions.

  • Mahendra Singhsaw the final versiontrailerTested older-server compatibility and combined -j/-P usage in #397, then reviewed help and error wording in #399; only light changes followed.
  • Amit Kapilasaw the final versiontrailerReviewed and revised validation, documentation, and help text in #398 and #405, then committed the final patch.
Fix the computation of max dead tuples during the vacuum.
22 Jan 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3902 of 2 reviewers saw the final version

Matches #390 except for parentheses around the MAXDEADTUPLES macro argument, requested by Dilip in #391 and confirmed at commit in #393.

  • Amit Kapilasaw the final versiontrailerCaught the undefined macro in #388, tested and revised the fix in #390, and committed it.
  • Dilip Kumarsaw the final versiontrailerReviewed MAXDEADTUPLES in #391 and supplied the argument-parenthesization correction used in the commit.
Allow vacuum command to process indexes in parallel.
20 Jan 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1Also in: cost based vacuum (parallel) (not this thread)
LLM analysis, 99% suremodified before commitlight changesfrom patchset #3792 of 4 reviewers saw the final version

The final attachment #379 differs only in comment corrections and typedef ordering. It already integrates cost-delay work from thread #41476 and postdates all that thread's supplied patchsets, making this the latest matching source.

  • Dilip Kumarsaw the final versiontrailerSupplied the final cost-pointer and worker-count corrections in #375 and tested throttling in #378, with those reviewed changes incorporated into #379.
  • Amit Kapilasaw the final versiontrailerPerformed sustained code review and revision, including the race and accounting fixes in #259, and committed the final version as confirmed in #383.
  • Robert Haassaw an earlier versiontrailerReviewed scheduling, worker reinitialization, statistics contracts, and throttling in #268 and #275, before substantial implementation and default-behavior changes.
  • Tomas Vondrasaw an earlier versiontrailerReviewed sizing, worker APIs, and default parallelism in #318 and #320, before default-on behavior, temporary-table handling, and argument validation changed.
Introduce IndexAM fields for parallel vacuum.
15 Jan 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1Also in: maintenance_work_mem used by Vacuum
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #3573 of 4 reviewers saw the final version

Exactly matches the IndexAM component of #357, adding amusemaintenanceworkmem and amparallelvacuumoptions; the execution component remained pending. The related memory-budget discussion thread #41328 has no attached patchsets.

  • Dilip Kumarsaw the final versiontrailerReviewed statistics and memory interfaces earlier, then evaluated the final bitmask representation and parallel-specific naming in #329 and #330.
  • Amit Kapilasaw the final versiontrailerRevised the AM interface and documentation through #310 and #357, then committed the API component as reported in #362.
  • Tomas Vondrasaw the final versiontrailerExamined field naming, memory flags, phase specificity, and bitmask representation in #318 and #320, after which the API received only light changes.
  • Robert Haassaw an earlier versiontrailerChallenged the unused estimator callback and incomplete statistics contract in #268 and #275, prompting substantive API simplification.

Mar 2019

3 commits
Allow existing VACUUM options to take a Boolean argument.
29 Mar 2019Robert Haasmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #661 of 2 reviewers saw the final version

Matches the Boolean-argument prerequisite in #66, including separate Boolean locals in ExecVacuum and documentation changes; the parallel vacuum and vacuumdb components were not included.

  • Haribabu Kommisaw an earlier versionLLM analysis, 95% sureIdentified PARALLEL documentation incorrectly included in the Boolean prerequisite in #60, before Robert's substantive Boolean-assignment correction in #65.
  • Robert Haassaw the final versioncommittercommitted the patch
Revise parse tree representation for VACUUM and ANALYZE.
18 Mar 2019Robert Haasmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #411 of 1 reviewer saw the final version

The grammar component of #41 exactly matches the commit's changed lines: DefElem options in gram.y, interpretation in ExecVacuum, and corresponding node and regression changes.

  • Robert Haassaw the final versioncommittercommitted the patch
Fold vacuum's 'int options' parameter into VacuumParams.
18 Mar 2019Robert Haasmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #410 of 1 reviewer saw the final version

Uses the VacuumParams component forwarded in #41, originally authored by Robert in #40. Robert additionally reworks vacuum_open_relation to retain the explicit option mask and take a verbose flag, preserving ANALYZE behavior as explained in #44.

  • Masahiko Sawadasaw an earlier versionLLM analysis, 95% sureReviewed Robert's patch and corrected its applicability and comments while forwarding it in #41, and is explicitly credited as reviewer in the commit; moderate vacuum_open_relation changes followed.

Credits across 7 commits

Author
Masahiko Sawada2 LLM6
Amit Kapila2
Robert HaasLLM1
with few modifications by me1
Reviewer
Amit Kapila4
Robert Haascommitter4
Dilip Kumar3
Tomas Vondra2
Mahendra Singh Thalor1
Tested by
Mahendra Singh Thalor1
Prabhat Sahu1
Reported by
Andres Freund1
Committer
Amit Kapila4
Robert Haas3

N LLM means N of the credits come from LLM analysis, not from commit trailers.