typcache.c typos
I've attached a patch to fix a typo in typcache.c. I ended up also
rephrasing the sentence since "information about data types that is",
almost made me also want to change "is" to "are", since "types" is
plural. That would have been a mistake since it's talking about the
information and not the types.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachments:
typcache_typos.patchapplication/octet-stream; name=typcache_typos.patchDownload
diff --git a/src/backend/utils/cache/typcache.c b/src/backend/utils/cache/typcache.c
index e38fd16eb0..aed4710ff2 100644
--- a/src/backend/utils/cache/typcache.c
+++ b/src/backend/utils/cache/typcache.c
@@ -3,8 +3,8 @@
* typcache.c
* POSTGRES type cache code
*
- * The type cache exists to speed lookup of certain information about data
- * types that is not directly available from a type's pg_type row. For
+ * The type cache exists to speedup lookups of certain information about data
+ * types that are not directly available from a type's pg_type row. For
* example, we use a type's default btree opclass, or the default hash
* opclass if no btree opclass exists, to determine which operators should
* be used for grouping and sorting the type (GROUP BY, ORDER BY ASC/DESC).
On 28 August 2018 at 16:40, David Rowley <david.rowley@2ndquadrant.com> wrote:
I've attached a patch to fix a typo in typcache.c. I ended up also
rephrasing the sentence since "information about data types that is",
almost made me also want to change "is" to "are", since "types" is
plural. That would have been a mistake since it's talking about the
information and not the types.
Opps. I mistakenly attached the incorrect patch. The correct one is
attached to this email.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachments:
typcache_typos_v2.patchapplication/octet-stream; name=typcache_typos_v2.patchDownload
diff --git a/src/backend/utils/cache/typcache.c b/src/backend/utils/cache/typcache.c
index e38fd16eb0..b06a7e3582 100644
--- a/src/backend/utils/cache/typcache.c
+++ b/src/backend/utils/cache/typcache.c
@@ -3,11 +3,11 @@
* typcache.c
* POSTGRES type cache code
*
- * The type cache exists to speed lookup of certain information about data
- * types that is not directly available from a type's pg_type row. For
- * example, we use a type's default btree opclass, or the default hash
- * opclass if no btree opclass exists, to determine which operators should
- * be used for grouping and sorting the type (GROUP BY, ORDER BY ASC/DESC).
+ * The type cache exists to speedup lookups of certain data type information
+ * that is not directly available from a type's pg_type row. For example, we
+ * use a type's default btree opclass, or the default hash opclass if no btree
+ * opclass exists, to determine which operators should be used for grouping
+ * and sorting the type (GROUP BY, ORDER BY ASC/DESC).
*
* Several seemingly-odd choices have been made to support use of the type
* cache by generic array and record handling routines, such as array_eq(),
Hi,
On 2018/08/28 13:42, David Rowley wrote:
On 28 August 2018 at 16:40, David Rowley <david.rowley@2ndquadrant.com> wrote:
I've attached a patch to fix a typo in typcache.c. I ended up also
rephrasing the sentence since "information about data types that is",
almost made me also want to change "is" to "are", since "types" is
plural. That would have been a mistake since it's talking about the
information and not the types.Opps. I mistakenly attached the incorrect patch. The correct one is
attached to this email.
- * The type cache exists to speed lookup of certain information about data
[ ... ]
+ * The type cache exists to speedup lookups of certain data type information
Sorry if I'm being ignorant, but shouldn't it be "to speed up or to
speed-up" instead of "to speedup?
Thanks,
Amit
On Tue, Aug 28, 2018 at 01:57:12PM +0900, Amit Langote wrote:
On 2018/08/28 13:42, David Rowley wrote:
On 28 August 2018 at 16:40, David Rowley <david.rowley@2ndquadrant.com> wrote:
I've attached a patch to fix a typo in typcache.c. I ended up also
rephrasing the sentence since "information about data types that is",
almost made me also want to change "is" to "are", since "types" is
plural. That would have been a mistake since it's talking about the
information and not the types.
Your new phrasing looks correct to me, as information about the type is
what is referenced, and not the data type itself.
- * The type cache exists to speed lookup of certain information about data
[ ... ]
+ * The type cache exists to speedup lookups of certain data type information
Sorry if I'm being ignorant, but shouldn't it be "to speed up or to
speed-up" instead of "to speedup?
I know "speed up" as a correct verb, and speedup can be used as a noun.
I don't know about "speed-up" though.
--
Michael
David Rowley <david.rowley@2ndquadrant.com> writes:
On 28 August 2018 at 16:40, David Rowley <david.rowley@2ndquadrant.com> wrote:
I've attached a patch to fix a typo in typcache.c. I ended up also
rephrasing the sentence since "information about data types that is",
almost made me also want to change "is" to "are", since "types" is
plural. That would have been a mistake since it's talking about the
information and not the types.
Opps. I mistakenly attached the incorrect patch. The correct one is
attached to this email.
I don't see any typos here; it looks to me more like a difference of
opinion about whether "information" is singular or plural. I don't
really feel a need to change the existing wording.
regards, tom lane
On 08/28/18 09:21, Michael Paquier wrote:
On Tue, Aug 28, 2018 at 01:57:12PM +0900, Amit Langote wrote:
- * The type cache exists to speed lookup of certain information about data [ ... ] + * The type cache exists to speedup lookups of certain data type informationSorry if I'm being ignorant, but shouldn't it be "to speed up or to
speed-up" instead of "to speedup?I know "speed up" as a correct verb, and speedup can be used as a noun.
I don't know about "speed-up" though.
Merriam-Webster has no problem with the original "to speed" (transitive
verb : to increase the speed of : accelerate), and it didn't bother me
either.
-Chap
On Tue, Aug 28, 2018 at 9:39 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Opps. I mistakenly attached the incorrect patch. The correct one is
attached to this email.I don't see any typos here; it looks to me more like a difference of
opinion about whether "information" is singular or plural. I don't
really feel a need to change the existing wording.
+1. "To speed up lookup" would be OK but I don't think "to speed
lookup" is wrong, and "to speedup lookup" does sound wrong.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 3 September 2018 at 10:24, Robert Haas <robertmhaas@gmail.com> wrote:
On Tue, Aug 28, 2018 at 9:39 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I don't see any typos here; it looks to me more like a difference of
opinion about whether "information" is singular or plural. I don't
really feel a need to change the existing wording.+1. "To speed up lookup" would be OK but I don't think "to speed
lookup" is wrong, and "to speedup lookup" does sound wrong.
Not sure where changing it to "to speedup lookup" was proposed. In
any case, it seems most people are happy the way it is. That's fine
for me.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services