[PATCH] Fix docs to JOHAB encoding on server side

Started by Lars Kanisover 7 years ago2 messages

lars@greiz-reinsdorf.de

over 7 years ago

1 attachment(s)

The current documentation is inconsistent about the JOHAB character encoding on server side. While the first table says that it is not possible to use JOHAB on server side, it is still listed in table 23.2 as a server character set:

https://www.postgresql.org/docs/devel/static/multibyte.html#MULTIBYTE-CHARSET-SUPPORTED

--
Kind Regards,
Lars

Attachments:

0001-Fix-docs-to-JOHAB-encoding-on-server-side.patchtext/x-patch; name=0001-Fix-docs-to-JOHAB-encoding-on-server-side.patchDownload

From 65d60fc66cf62af9ea2d570590a541fbdf397767 Mon Sep 17 00:00:00 2001
From: Lars Kanis <lars@greiz-reinsdorf.de>
Date: Sat, 1 Sep 2018 18:03:14 +0200
Subject: [PATCH] Fix docs to JOHAB encoding on server side

This is probably left over from commit 6041b92238897b06fe7bbe229a6e99f80121fa4a .
---
 doc/src/sgml/charset.sgml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml
index dc3fd34a62..452e625e01 100644
--- a/doc/src/sgml/charset.sgml
+++ b/doc/src/sgml/charset.sgml
@@ -1538,8 +1538,7 @@ $ <userinput>psql -l</userinput>
         </row>
         <row>
          <entry><literal>JOHAB</literal></entry>
-         <entry><emphasis>JOHAB</emphasis>,
-         <literal>UTF8</literal>
+         <entry><emphasis>not supported as a server encoding</emphasis>
          </entry>
         </row>
         <row>
-- 
2.17.1

Tom Lane

tgl@sss.pgh.pa.us

over 7 years ago

In reply to: Lars Kanis (#1)

Re: [PATCH] Fix docs to JOHAB encoding on server side

Lars Kanis <lars@greiz-reinsdorf.de> writes:

The current documentation is inconsistent about the JOHAB character encoding on server side. While the first table says that it is not possible to use JOHAB on server side, it is still listed in table 23.2 as a server character set:
https://www.postgresql.org/docs/devel/static/multibyte.html#MULTIBYTE-CHARSET-SUPPORTED

Hm, yeah. Probably this is because JOHAB was first installed as being
a server-allowed encoding, and it was only later we realized that wasn't
OK. This table must've been missed while changing it.

Cross-checking the other entries, I notice SHIFT_JIS_2004 is also not
listed in that table ... we've been a little sloppy there.

Thanks for noticing!

regards, tom lane