review printing ecpg program version

Started by Ioseph Kimover 7 years ago6 messages
#1Ioseph Kim
pgsql-kr@postgresql.kr

hi,

I found a little problem about printing ecpg version.

unlike PostgreSQL ver.11 other programs, ecpg version string has only
version number.

$ ./ecpg --version
ecpg 11beta3

$ ./psql --version
psql (PostgreSQL) 11beta3

$ ./pg_dump --version
pg_dump (PostgreSQL) 11beta3

I hope PostgreSQL product name be included in ecpg version string,

It will clarify version between other products (ex. EnterpriseDB
Postgres, GP, ...)

Regards, Ioseph.

#2Ioseph Kim
pgsql-kr@postgresql.kr
In reply to: Ioseph Kim (#1)
Re: review printing ecpg program version

check please pg_config --version too.

2018占쏙옙 09占쏙옙 12占쏙옙 15:52占쏙옙 Ioseph Kim 占쏙옙(占쏙옙) 占쏙옙 占쏙옙:

Show quoted text

hi,

I found a little problem about printing ecpg version.

unlike PostgreSQL ver.11 other programs, ecpg version string has only
version number.

$ ./ecpg --version
ecpg 11beta3

$ ./psql --version
psql (PostgreSQL) 11beta3

$ ./pg_dump --version
pg_dump (PostgreSQL) 11beta3

I hope PostgreSQL product name be included in ecpg version string,

It will clarify version between other products (ex. EnterpriseDB
Postgres, GP, ...)

Regards, Ioseph.

#3Michael Paquier
michael@paquier.xyz
In reply to: Ioseph Kim (#2)
Re: review printing ecpg program version

On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:

check please pg_config --version too.

Well, one problem with that is that you would break a ton of stuff which
parse this version string automatically. pg_config --version is used by
many extensions to guess which version of Postgres is being worked on.
--
Michael

#4Ioseph Kim
pgsql-kr@postgresql.kr
In reply to: Michael Paquier (#3)
Re: review printing ecpg program version

ok, in case pg_config, ignore this, but It should be review in case ecpg.

2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글:

Show quoted text

On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:

check please pg_config --version too.

Well, one problem with that is that you would break a ton of stuff which
parse this version string automatically. pg_config --version is used by
many extensions to guess which version of Postgres is being worked on.
--
Michael

#5Peter Eisentraut
peter.eisentraut@2ndquadrant.com
In reply to: Ioseph Kim (#4)
Re: review printing ecpg program version

On 12/09/2018 10:32, Ioseph Kim wrote:

ok, in case pg_config, ignore this, but It should be review in case ecpg.

fixed

2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글:

On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:

check please pg_config --version too.

Well, one problem with that is that you would break a ton of stuff which
parse this version string automatically. pg_config --version is used by
many extensions to guess which version of Postgres is being worked on.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#6Michael Paquier
michael@paquier.xyz
In reply to: Peter Eisentraut (#5)
Re: review printing ecpg program version

On Wed, Sep 12, 2018 at 02:41:11PM +0200, Peter Eisentraut wrote:

On 12/09/2018 10:32, Ioseph Kim wrote:

ok, in case pg_config, ignore this, but It should be review in case ecpg.

fixed

Thanks Peter for jumping in the ship. What you did looks correct to
me.
--
Michael