Dec 2018

1 commit
Ensure cleanup of orphan archive status files
10 Dec 2018Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #232 of 4 reviewers saw the final version

The commit retains the ENOENT check and cleanup retry loop from #23 in src/backend/postmaster/pgarch.c, but replaces durable_unlink() with unlink(), renames the cleanup counter and constant, and adds explanatory comments. The behavioral change follows #25 and #27, and the committer confirms the edits in #29.

  • Nathan Bossartsaw the final versiontrailerNathan questioned startup cost in #10, requested ENOENT handling and retries in #14, tested the revised code in #22, reviewed the final attachment in #24, and accepted the subsequent unlink() change in #28.
  • Andres Freundsaw an earlier versiontrailerAndres identified the remaining crash window and additional cost of durable deletion in #2 and #4, before the implementation underwent two major reworks.
  • Stephen Frostsaw an earlier versiontrailerStephen proposed handling missing WAL files in the archiver in #5 and outlined archiver-time and recovery-time cleanup alternatives in #7, before the replacement implementations were posted.
  • Kyotarosaw the final versiontrailerKyotaro discussed an alternative to the recovery scan in #11 and identified durable_unlink() retry failures in the final attachment in #25, prompting the committed switch to unlink().

Credits across 1 commit

Author
Michael Paquier1
Reviewer
Andres Freund1
Kyotaro1
Nathan Bossart1
Stephen Frost1
Committer
Michael Paquier1