Oid returned from AddSubscriptionRelState/UpdateSubscriptionRelState

Started by Andres Freundalmost 8 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t39424
psql -h localhost -U postgres

Built from patchset v2 (message #2), July 28, 2026 at 05:10 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t39424_2 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t39424_2 && git checkout t39424_2

Patchset v2 (message #2) is on t39424_2

Jump to latest
#1Andres Freund
andres@anarazel.de

Hi,

How come those two functions return oids, even though, as far as I
understand, the underlying relation is BKI_WITHOUT_OIDS. I assume
that's just an oversight?

Greetings,

Andres Freund

#2Petr Jelinek
petr@2ndquadrant.com
In reply to: Andres Freund (#1)
Re: Oid returned from AddSubscriptionRelState/UpdateSubscriptionRelState

Hi,

On 29/09/18 03:35, Andres Freund wrote:

How come those two functions return oids, even though, as far as I
understand, the underlying relation is BKI_WITHOUT_OIDS. I assume
that's just an oversight?

Yeah, it's copy-pasto that managed to get through, those functions
should return void.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

t39424_2
0001-Fix-return-value-of-subscription-relation-mapping-ma.patchtext/x-patch; name=0001-Fix-return-value-of-subscription-relation-mapping-ma.patchDownload+5-14