Nov 2018

2 commits
Remove volatiles from {procarray,volatile}.c and fix memory ordering issue.
11 Nov 2018Andres Freundmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 moreAlso in: A misconception about the meaning of 'volatile' in GetNewTransactionId?
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #9

The commit retains the changes from #9, simplifies GetNewTransactionId(), expands its ordering comments, and adds a pg_write_barrier() in XidCacheRemove. This November submission is newer than the February patch in thread #36606; Andres credits Thomas Munro's earlier work for the additional write-ordering fix in #11, and the commit credits him as a contributing author.

Combine two flag tests in GetSnapshotData().
10 Nov 2018Andres Freundmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surewritten from the discussion, no matching patch

Andres proposed combining redundant flag tests in #8; the commit combines PROC_IN_LOGICAL_DECODING and PROC_IN_VACUUM checks in GetSnapshotData() in src/backend/storage/ipc/procarray.c. It landed before #9, whose attached patch already uses the combined test as its base.

Credits across 2 commits

Author
Andres Freund2
with cherrypicked changes from a patch by Thomas Munro1
Reported by
Andres Freund1
Thomas Munro1
Committer
Andres Freund2