Apr 2019

2 commits
Fix bugs in mdsyncfiletag().
5 Apr 2019Thomas Munromaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surewritten from the discussion, no matching patch

Thomas identified the incorrect _mdfd_getseg() arguments through RELSEG_SIZE=1 testing in #91, without attaching a patch. The commit converts segment numbers to block numbers, adds EXTENSION_DONT_CHECK_SIZE, preserves errno, and simplifies mdunlinkfiletag() in src/backend/storage/smgr/md.c.

Refactor the fsync queue for wider use.
4 Apr 2019Thomas Munromaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #822 of 2 reviewers saw the final version

Applying the first patch of #82 to the commit's parent confirms that it supplies the refactoring, while the SLRU proof of concept is omitted as announced in #79; its header credits Shawn Debnath and Thomas Munro. Committer edits change FileTag.segno to uint32, restore an md.c declaration, remove redundant smgropen(), adjust naming/comments, and remove the SYNC_REQUEST restriction on backend-fsync accounting.

  • Thomas Munrosaw the final versiontrailerThomas reviewed interfaces and descriptor handling in #53, detected the slowdown in #66, tested the interface in #74, and finalized and committed the version announced in #87.
  • Andres Freundsaw the final versiontrailerAndres challenged the locking and SMGR layering in #4, #33, and #36, reviewed request representation in #54, and reviewed the final source patch's segment type in #84, prompting the committed uint32 change.

Credits across 2 commits

Author
Thomas Munro2
Shawn Debnath1
Reviewer
Andres Freund1
Thomas Munro1
Committer
Thomas Munro2