Unordered wait event ClogGroupUpdate
Hi all,
baaf272 has added support for group updates in clog, however it has
added the wait event WAIT_EVENT_CLOG_GROUP_UPDATE in a non-alphabetical
order. There are many events, so keeping things in order helps users in
finding them.
Are there any objections to the attached, which reorders things
properly? This is a patch for HEAD, for v11 I propose to only fix the
documentation side of things to avoid an ABI breakage.
I checked the other wait events and things are in order.
Thanks,
--
Michael
Attachments:
fix-clog-event.patchtext/x-diff; charset=us-asciiDownload+8-8
On Wed, Oct 24, 2018 at 5:56 AM Michael Paquier <michael@paquier.xyz> wrote:
baaf272 has added support for group updates in clog, however it has
added the wait event WAIT_EVENT_CLOG_GROUP_UPDATE in a non-alphabetical
order. There are many events, so keeping things in order helps users in
finding them.
That's a valid argument. Additionally, I've found
WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING and
WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING are added in a
non-alphabetical order in WaitEventIPC enum.
Are there any objections to the attached, which reorders things
properly? This is a patch for HEAD, for v11 I propose to only fix the
documentation side of things to avoid an ABI breakage.
+1
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
On Wed, Oct 24, 2018 at 10:25:37AM +0530, Kuntal Ghosh wrote:
That's a valid argument. Additionally, I've found
WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING and
WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING are added in a
non-alphabetical order in WaitEventIPC enum.
Indeed, thanks for double-checking.
And those ones are also incorrect after another lookup:
- WAIT_EVENT_PARALLEL_FINISH
- WAIT_EVENT_HASH_GROW_BATCHES_DECIDING
- WAIT_EVENT_LOGICAL_APPLY_MAIN
I don't see more of them..
--
Michael
On Wed, Oct 24, 2018 at 10:48 AM Michael Paquier <michael@paquier.xyz> wrote:
That's a valid argument. Additionally, I've found
WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING and
WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING are added in a
non-alphabetical order in WaitEventIPC enum.And those ones are also incorrect after another lookup:
- WAIT_EVENT_PARALLEL_FINISH
- WAIT_EVENT_HASH_GROW_BATCHES_DECIDING
- WAIT_EVENT_LOGICAL_APPLY_MAIN
I don't see more of them..
Nice. Same here.
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
On Wed, Oct 24, 2018 at 10:59:35AM +0530, Kuntal Ghosh wrote:
Nice. Same here.
Thanks for confirming. I have committed the change, with HEAD making
the structures and the documentation consistent. Down to 10, only the
documentation has been changed, where it is adapted.
--
Michael