notice processors for isolationtester

Started by Alvaro Herreraover 7 years ago4 messageshackers
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

Recently while testing a patch I found it immensely useful to
distinguish which session each WARNING message came from, when bespoke
tests were run under isolationtester. Current code does not show that,
so I developed this patch adding notice processors, and then it does.

--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

isolationtester-notices.patchtext/x-diff; charset=us-asciiDownload+50-19
#2Andres Freund
andres@anarazel.de
In reply to: Alvaro Herrera (#1)
Re: notice processors for isolationtester

On 2018-10-24 18:34:51 -0300, Alvaro Herrera wrote:

Recently while testing a patch I found it immensely useful to
distinguish which session each WARNING message came from, when bespoke
tests were run under isolationtester. Current code does not show that,
so I developed this patch adding notice processors, and then it does.

Neat!

#3Haribabu Kommi
kommi.haribabu@gmail.com
In reply to: Alvaro Herrera (#1)
Re: notice processors for isolationtester

On Thu, Oct 25, 2018 at 8:35 AM Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

Recently while testing a patch I found it immensely useful to
distinguish which session each WARNING message came from, when bespoke
tests were run under isolationtester. Current code does not show that,
so I developed this patch adding notice processors, and then it does.

I reviewed and tested the patch. It is working as expected.
Providing session name helps in debugging.

Marking the patch as ready for committer.

Regards,
Haribabu Kommi
Fujitsu Australia

#4Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Haribabu Kommi (#3)
Re: notice processors for isolationtester

On 2018-Nov-09, Haribabu Kommi wrote:

On Thu, Oct 25, 2018 at 8:35 AM Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

Recently while testing a patch I found it immensely useful to
distinguish which session each WARNING message came from, when bespoke
tests were run under isolationtester. Current code does not show that,
so I developed this patch adding notice processors, and then it does.

I reviewed and tested the patch. It is working as expected.
Providing session name helps in debugging.

Marking the patch as ready for committer.

Thanks! Pushed.

--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services