Mar 2019

1 commit
Fix WAL format incompatibility introduced by backpatching of 52ac6cd2d0
24 Mar 2019Alexander KorotkovREL_11_STABLE11.3REL_10_STABLE10.8REL9_6_STABLE9.6.13REL9_5_STABLE9.5.17REL9_4_STABLE9.4.22
LLM analysis, 100% surelanded as postedfrom patchset #452 of 2 reviewers saw the final version

The diff exactly matches #45, including the ginxlog.c length checks and ginxlogDeletePageOld definition in src/include/access/ginxlog.h; #47 confirms the push.

  • Simon Riggssaw the final versiontrailerIn #43, he requested checking that record length matches either supported format, which the final revision implements through assertions.
  • Alvaro Herrerasaw the final versiontrailerIn #44, he requested an explanatory comment for the compatibility check, followed only by comments and assertion additions.

Dec 2018

4 commits
Fix wrong backpatching of ginRedoDeletePage() deadlock fix
13 Dec 2018Alexander KorotkovREL9_4_STABLE9.4.21
LLM analysis, 100% surewritten from the discussion, no matching patch

No attachment matches this PostgreSQL 9.4 correction to buffer initialization and lock lifetimes in ginRedoDeletePage(). It follows the warning reports and double-release diagnosis in #34, #35, and #36, with the repair announced in #37.

Fix deadlock in GIN vacuum introduced by 218f51584d5
13 Dec 2018Alexander Korotkovmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+3 more
LLM analysis, 100% surelanded as postedfrom patchset #271 of 1 reviewer saw the final version

The ginvacuum.c and GIN README diffs exactly match #27, the latest submission of the code first posted in #21.

  • Andrey Borodinsaw the final versiontrailerIn #22, he examined direct FirstOffsetNumber access versus getLeftMostChild(), and the subsequent submitted revision changed only the commit message.
Prevent deadlock in ginRedoDeletePage()
13 Dec 2018Alexander Korotkovmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+6 more
LLM analysis, 100% surelanded as postedfrom patchset #30

The ginxlog.c diff exactly matches #30, moving left-sibling locking ahead of the deleted page and parent. The unlock-order discussion beginning in #33 occurred after this commit.

Prevent GIN deleted pages from being reclaimed too early
13 Dec 2018Alexander Korotkovmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+6 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #311 of 1 reviewer saw the final version

Retains the deletion-XID stamping, WAL field, and both RecentGlobalXmin checks from #31. Committer edits consolidate equivalent checks into GinPageIsRecyclable(), move macros into ginblock.h, and update the GIN README; #32 confirms revision before pushing.

  • Alexander Korotkovsaw the final versiontrailerHe identified missing normal-operation and WAL initialization in #26, requested horizon and FSM consistency in #29, and revised and committed the final patch as confirmed in #32.

Credits across 5 commits

Author
Alexander Korotkov4
Andrey Borodin1
based on ideas from Andrey Borodin1
Peter Geoghegan1
Reviewer
Alexander Korotkov1
Alvaro Herrera1
Andrey Borodin1
Simon Riggs1
Reported by
Chen Huajun2
Bruce Momjian1
Simon Riggs1
Committer
Alexander Korotkov5