prewarm compiler warnings

Started by Erik Rijkersover 7 years ago2 messageshackers
Jump to latest
#1Erik Rijkers
er@xs4all.nl

gcc-6.3.0 complains about this:

autoprewarm.c: In function ‘autoprewarm_main’:
autoprewarm.c:210:9: warning: variable ‘rc’ set but not used
[-Wunused-but-set-variable]
int rc;

The warning comes only in master.

The warnings are a bit annoying; the attached silences them by removing
those assignments.

Thanks,

Erik Rijkers

Attachments:

prewarm-fix.difftext/x-diff; name=prewarm-fix.diffDownload+2-4
#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Erik Rijkers (#1)
Re: prewarm compiler warnings

On 2018-Nov-23, Erik Rijkers wrote:

gcc-6.3.0 complains about this:

autoprewarm.c: In function ‘autoprewarm_main’:
autoprewarm.c:210:9: warning: variable ‘rc’ set but not used
[-Wunused-but-set-variable]
int rc;

The warning comes only in master.

Yeah, it's fairly new. I noticed a couple of other places that could
use the same adjustment and pushed them all together. (I used a cast to
void as all other places do that, which appeases Coverity about the
discrepancy.)

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services