model-writtenrun 9777 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Amit Langote opened the thread because calling a partitioned subscription target 'not a table' was confusing, proposing a specific error and explanatory detail in #1 and implementing it in #4 without new tests because he found no existing unsupported-relation-kind tests in subscription.sql.
- Michael Paquier asked about other relation kinds in #5, and Magnus Hagander supported including foreign tables in #7; Amit rejected special handling for TOAST tables because they are not user-defined in #9, then added the foreign-table case in #10.
- Michael’s conditional-style review in #12 led to an else-if revision in #13, while Peter Eisentraut’s comment-placement review in #14 led Amit to consolidate the explanation above the checks in #15.
- Michael proposed an action-focused primary error with the relation type in the detail in #16 and #18; Amit adopted that wording in #19 and also proposed changing the error code to FEATURE_NOT_SUPPORTED.
- Michael argued for retaining WRONG_OBJECT_TYPE and making the generic error consistent in #20 and #22, then supplied the complete revised patch in #23.
- Amit remained concerned about how users would interpret the wording in #24, but Arkhena pointed to the documented restriction in #25 and Michael explained the existing replication model in #27; Amit withdrew his objection in #28.
- Michael committed #23 unchanged as 373bda61d2, crediting Amit as author, and announced completion in #30; Amit’s thanks in #31 closed the thread with no remaining patch work identified.