Jan 2019

4 commits
Add test case for ON DELETE NO ACTION/RESTRICT
16 Jan 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The 12 insertions and four deletions match the first patch in #1, adding ON DELETE NO ACTION/RESTRICT failures to foreign_key.sql and foreign_key.out.

  • Alvaro Herrerasaw the final versiontrailerAlvaro examined ri_restrict's partition-dependent ONLY handling in #4 and concluded that existing partitioned-table coverage made further changes unnecessary here.
  • Mi Tarsaw the final versiontrailerMitar reported clean application and successful make installcheck-world for the unchanged submitted patch in #5.
Increase test coverage in RI_FKey_pk_upd_check_required()
16 Jan 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

All 43 added lines match the second patch in #1, covering deletion of a referenced-table row with a partially null unique key in foreign_key.sql and foreign_key.out.

  • Alvaro Herrerasaw the final versiontrailerAlvaro examined the null-check tuple descriptor in #4 and concluded that partitioned referenced tables were not yet supported, so the concern did not block this unchanged patch.
  • Mi Tarsaw the final versiontrailerMitar reported clean application and successful make installcheck-world for the unchanged submitted patch in #5.
Increase test coverage in RI_FKey_fk_upd_check_required()
16 Jan 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 2 reviewers saw the final version

The commit retains the third patch from #1, including partial-null and unchanged-key updates, and adds a partitioned referencing table whose MATCH FULL constraint rejects a partially null insert. The added scenario contributes 17 lines across foreign_key.sql and foreign_key.out.

  • Alvaro Herrerasaw an earlier versiontrailerAlvaro examined partition-related tuple-descriptor risks for this patch in #4, before the new partitioned-table MATCH FULL test was added.
  • Mi Tarsaw an earlier versiontrailerMitar reported that the submitted series applied cleanly and passed make installcheck-world in #5, before the additional partitioned-table scenario.
Increase test coverage in RI_Initial_Check()
16 Jan 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 2 reviewers saw the final version

The commit preserves the fourth patch from #1 and adds a partitioned-table MATCH FULL validation failure during ALTER TABLE, with corresponding expected output. Peter confirmed these additional partitioned-table tests in #6.

  • Alvaro Herrerasaw an earlier versiontrailerAlvaro requested partitioned-table coverage in #2 and explained the risks in #4, before the additional partitioned-table case was implemented.
  • Mi Tarsaw an earlier versiontrailerMitar reported successful application and make installcheck-world in #5, before the partitioned-table validation case was added.

Credits across 4 commits

Author
Peter EisentrautLLM4
Reviewer
Alvaro Herrera4
Mitar4
Committer
Peter Eisentraut4

N LLM means N of the credits come from LLM analysis, not from commit trailers.