Jan 2019

2 commits
Don't create relfilenode for relations without storage
4 Jan 2019Alvaro Herreramaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #52 of 2 reviewers saw the final version

The commit preserves the logic and regression tests of #5, substituting RELKIND_HAS_STORAGE and adding a tablespace-inheritance comment in src/backend/catalog/heap.c. It also bumps src/include/catalog/catversion.h because the new sanity check requires freshly initialized catalogs.

  • Kyotaro HORIGUCHIsaw the final versiontrailerResponding to #4, he examined mapped relations and physical-address handling, confirmed regression tests passed and recommended the final macro name in #6; only a rebase and light edits followed.
  • Michael Paquiersaw the final versiontrailerHe questioned relfilenode handling and requested a macro and tests in #3, then reconsidered index reuse and reviewed the revised boolean and test in #7.
Rename macro to RELKIND_HAS_STORAGE
4 Jan 2019Alvaro Herreramaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

No attachment performs this rename: #6 and #8 argue for RELKIND_HAS_STORAGE, and #11 requests a separate commit covering commands/copy.c. The commit renames the existing definition in pg_class.h and its callers in copy.c and tablecmds.c.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 95% sureReviewing the macro introduced in #4, he explained why mapped relations still have storage and proposed the adopted RELKIND_HAS_STORAGE name in #6.
  • Amit Langotesaw the final versionLLM analysis, 91% sureHe examined the macro introduced in #4 and its tablespace assertion, explaining in #8 why the adopted name accurately describes both mapped and unmapped relations.
  • Michael Paquiersaw the final versionLLM analysis, 86% sureHe identified the additional copy.c caller and requested an independent rename commit in #11, both reflected in the committed discussion-derived change.

Credits across 2 commits

Author
Alvaro HerreraLLM1
Reviewer
Kyotaro Horiguchi1
Michael Paquier1
Committer
Alvaro Herrera2

N LLM means N of the credits come from LLM analysis, not from commit trailers.