Nov 2019

3 commits
Fix nested error handling in PG_FINALLY
7 Nov 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #161 of 1 reviewer saw the final version

Matches both file changes in #16, with the redundant else and braces after the nonreturning PG_RE_THROW() removed. Tom Lane requested that stylistic simplification in #17, and Peter confirmed it in #18.

  • Tom Lanesaw the final versiontrailerIn #17, he reviewed the fix and proposed removing the redundant else after PG_RE_THROW(), which was adopted.
Fix some compiler warnings on older compilers
4 Nov 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Initializes five result variables in XML, PL/Perl, PL/Python, and PL/Tcl code following Tom Lane's compiler-warning report #13. No attached patch contains these initializations; Peter described reproducing and fixing the warnings on CentOS 6 in #14.

PG_FINALLY
1 Nov 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #82 of 5 reviewers saw the final version

All caller conversions match #8; the substantive diff differences are confined to prefixing macro-local names with underscores in src/include/utils/elog.h. This implements Tom Lane's naming request #11, as confirmed by Peter in #12.

  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 97% sureIn #2, he proposed the separate PG_FINALLY() cleanup-block syntax subsequently implemented in #8, although his initial control-flow sketch needed correction.
  • Andrew Dunstansaw an earlier versionLLM analysis, 86% sureIn #3, he analyzed the macro-block syntax's pgindent incompatibility and objected to enclosing the block in parentheses, which the redesign in #8 eliminated.
  • David Steelesaw an earlier versionLLM analysis, 88% sureIn #4, he supplied a concrete FINALLY implementation and advocated keeping it within the TRY construct, the structure adopted in #8.
  • Tom Lanesaw the final versionLLM analysis, 100% sureHe challenged duplicated cleanup expansion and specified the revised syntax in #7, then requested the macro-local underscore naming adopted before commit in #11.
  • Robert Haassaw the final versionLLM analysis, 97% sureIn #9, he inspected the converted call sites and identified the do_rethrow name-collision risk subsequently addressed by underscore-prefixed names.

Credits across 3 commits

Author
Peter EisentrautLLM2
Reviewer
Tom Lane1
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.