Dec 2019

2 commits
Emit parameter values during query bind/execute errors
11 Dec 2019Alvaro Herreramaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #680 of 3 reviewers saw the final version

The implementation matches #68; committer edits clarify BuildParamLogString comments and extend src/bin/pgbench/t/001_pgbench_with_server.pl to verify duration logging preserves complete values. The commit explicitly credits Alexey Bashtanov alongside sender Alvaro Herrera.

  • Peter Eisentrautsaw an earlier versiontrailerPeter reviewed APIs, tested performance and existing logging behavior, and requested broader tests in #2, #7, #10, #14, and #17, before the callback-based redesign.
  • Andres Freundsaw an earlier versiontrailerAndres reviewed lifetime and formatting concerns and advocated prebuilt strings and error callbacks in #12, #21, #23, #28, and #37, before subsequent callback and caching changes.
  • Tom Lanesaw an earlier versiontrailerTom identified DETAIL clobbering, inadequate tests, multibyte truncation, allocation issues, and callback-data lifetime concerns in #40 and #45, after which substantive fixes and the string-return API change followed.
Add backend-only appendStringInfoStringQuoted
10 Dec 2019Alvaro Herreramaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #641 of 1 reviewer saw the final version

Matches #64 except for declaration ordering and an equivalent simplification of the final non-truncated append in src/backend/utils/mb/stringinfo_mb.c. The commit credits Alexey Bashtanov as co-author, consistent with Alvaro Herrera's extraction acknowledgment in #32.

  • Tom Lanesaw the final versiontrailerTom reviewed truncation correctness in #45 and the backend-only helper's placement, declarations, and documentation in #59, followed only by light cleanup and header corrections.

Credits across 2 commits

Author
Alexey Bashtanov2
Alvaro Herrera2
after a suggestion from Andres Freund1
Reviewer
Tom Lane2
Andres Freund1
Peter Eisentraut1
Committer
Alvaro Herrera2