Jan 2019

3 commits
Use perfect hashing, instead of binary search, for keyword lookup.
10 Jan 2019Tom Lanemaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% suremodified before commitlight changesfrom patchset #801 of 2 reviewers saw the final version

Applying #80 to the commit parent reproduces the hashing implementation; remaining differences are case-fold option naming and explanatory comments, including keyword-header ordering comments. These edits follow review in #89 and #95; the macro removal in #90 was not included.

  • John Naylorsaw the final versionLLM analysis, 100% sureReviewed module exports, case-fold options, algorithm comments, and keyword-header warnings in #76 and #95, and is explicitly credited for review in c64d0cd5ce.
  • Andres Freundsaw an earlier versionLLM analysis, 98% sureRequested extraction of the posted generator into a reusable Perl module in #67, which was implemented before subsequent hash-table and parameter-search changes.
Reduce the size of the fmgr_builtin_oid_index[] array.
9 Jan 2019Tom Lanemaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #811 of 1 reviewer saw the final version

The changes in src/backend/utils/Gen_fmgrtab.pl, src/backend/utils/fmgr/fmgr.c, and src/include/utils/fmgrtab.h exactly match #81, including fmgr_last_builtin_oid and the shortened index array.

  • Andres Freundsaw the final versionLLM analysis, 94% sureExamined the new external upper-bound reference and its efficiency tradeoff in #83 before the unchanged patch was committed.
Replace the data structure used for keyword lookup.
6 Jan 2019Tom Lanemaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #581 of 3 reviewers saw the final version

Compared with #58, the commit adds generated max_kw_len data and early length rejection in both lookup functions, simplifies an include, and fixes an ECPG dependency; #64 confirms this landing. The commit credits John Naylor with further hacking by Tom Lane.

  • Andres Freundsaw an earlier versionLLM analysis, 100% sureTested #42 and diagnosed missing frontend keyword definitions and rebuild-dependency problems in #43, before the subsequent API refactoring.
  • Andrew Dunstansaw an earlier versionLLM analysis, 98% sureProposed replacing the posted generator's argument parsing with Getopt::Long in #35, which John implemented in #42 before later structural changes.
  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Tom LaneLLM2
John NaylorLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.