WRITE_*_ARRAY macros for outfuncs.c

Started by Peter Eisentrautover 7 years ago2 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

In readfuncs.c, we have READ_ATTRNUMBER_ARRAY, READ_OID_ARRAY,
READ_INT_ARRAY, READ_BOOL_ARRAY, but the writing side in outfuncs.c is
coded by hand in each case. Any reason for this?

Here is a patch that adds WRITE_ATTRNUMBER_ARRAY, WRITE_OID_ARRAY,
WRITE_INT_ARRAY, WRITE_BOOL_ARRAY. That seems much nicer.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

0001-Add-WRITE_-_ARRAY-macros.patchtext/plain; charset=UTF-8; name=0001-Add-WRITE_-_ARRAY-macros.patch; x-mac-creator=0; x-mac-type=0Download+67-182
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: WRITE_*_ARRAY macros for outfuncs.c

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

In readfuncs.c, we have READ_ATTRNUMBER_ARRAY, READ_OID_ARRAY,
READ_INT_ARRAY, READ_BOOL_ARRAY, but the writing side in outfuncs.c is
coded by hand in each case. Any reason for this?

Here is a patch that adds WRITE_ATTRNUMBER_ARRAY, WRITE_OID_ARRAY,
WRITE_INT_ARRAY, WRITE_BOOL_ARRAY. That seems much nicer.

LGTM.

regards, tom lane