Jan - Feb 2019

3 commits
Move page initialization from RelationAddExtraBlocks() to use, take 2.
3 Feb 2019Andres Freundmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% suremodified before commitlight changesfrom patchset #220 of 1 reviewer saw the final version

The implementation in #22 matches the committed changes in src/backend/access/heap/hio.c and vacuumlazy.c, including RBM_ZERO_AND_LOCK and the other-buffer retry path. Beyond rebasing, the commit adjusts comments and commit-message wording.

  • Tom Lanesaw an earlier versiontrailerTom reviewed comments and FSM logic in #10, but the substantial extension-locking rework in #22 followed without a further patch review from him in this thread.
Fix race condition between relation extension and vacuum.
28 Jan 2019Andres Freundmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surewritten from the discussion, no matching patch

This implements Andres's inline proposal in #13 to restore the extension-lock interlock and recheck PageIsNew before recording free space in vacuumlazy.c. No attached patchset represents this temporary repair, which Andres reported pushing in #15.

Move page initialization from RelationAddExtraBlocks() to use.
28 Jan 2019Andres Freundmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #80 of 1 reviewer saw the final version

The commit implements #8, incorporating Tom's comment corrections and FSM simplification while removing DEBUG logging. It also changes lazy_check_needs_freeze() to return false for new pages, an additional functional change explicitly described in #11.

  • Tom Lanesaw an earlier versiontrailerTom proposed concrete comment and FSM-code improvements in #10, before the additional lazy_check_needs_freeze() behavior change documented in #11.

Credits across 3 commits

Author
Andres Freund3
Reviewer
Tom Lane2
Committer
Andres Freund3