Feb 2019

3 commits
Make use of compiler builtins and/or assembly for CLZ, CTZ, POPCNT.
16 Feb 2019Tom Lanemaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 97% suremodified before commitsignificant changesfrom patchset #471 of 3 reviewers saw the final version

Combines the original consumers from #11 with the inline CLZ/CTZ and builtin-fallback design finalized in #47. Tom Lane substantially rewrote POPCNT dispatch using x86_64 assembly, replaced configure probes with generic link checks, exported shared lookup tables, and converted additional GiST consumers; the commit credits Rowley, Munro, Herrera, and Lane.

  • Dmitry Dolgovsaw an earlier versionLLM analysis, 97% sureTested #1, reported a small speedup and Clang's automatic POPCNT generation in bloom_prop_bits_set, and suggested converting that consumer in #4, before substantial later reworking.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 86% sureRaised zero-input and unsupported-LZCNT correctness concerns about the builtin implementation in #40, prompting the checks and clarification in #41 and #42, before the final structural rewrite.
  • Tom Lanesaw the final versioncommittercommitted the patch
Fix compiler builtin usage in new pg_bitutils.c
15 Feb 2019Alvaro Herreramaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #471 of 2 reviewers saw the final version

Applying #47 to the commit's parent produces identical contents for every patched file, including configure, pg_bitutils.h, pg_bitutils.c, and pg_bitutils_hwpopcnt.c; apparent diff differences are hunk alignment only.

  • Tom Lanesaw the final versionLLM analysis, 99% sureDirected the inline CLZ/CTZ and independent configure checks in #33 and #38, tested POWER compiler behavior in #45, and identified header-table warning risks in the final patch in #48.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 86% sureReviewed builtin correctness in #40, leading to nonzero-argument checks and rejection of forced LZCNT usage, while subsequent versions also changed configure and hardware-object selection.
Add basic support for using the POPCNT and SSE4.2s LZCNT opcodes
13 Feb 2019Alvaro Herreramaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #111 of 2 reviewers saw the final version

The added and removed code matches #11, including the new src/port helpers, visibility-map and bitmapset conversions, and bloom-filter integration; differences are surrounding base context and placement of the unchanged Makefile addition.

  • Dmitry Dolgovsaw an earlier versionLLM analysis, 98% sureReported testing and Clang-generated POPCNT in bloom_prop_bits_set in #4, which informed the buffer-counting consumer and compiler-flag changes in #11.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Alvaro HerreraLLM2
David RowleyLLM1
Reviewer
Alvaro Herreracommitter1
Tom Lanecommitter1
Committer
Alvaro Herrera2
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.