Mar 2019

7 commits
Reorganize Notes section in documentation of pg_checksums
29 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1461 of 1 reviewer saw the final version

Implements the paragraph reordering and replication guidance from #146 in doc/src/sgml/ref/pg_checksums.sgml, with revised wording about the checksum configuration and restarting the operation, discussed in #147.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Add option -N/--no-sync to pg_checksums
22 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1331 of 3 reviewers saw the final version

Commits only the --no-sync component of the two-patch series in #133; applying that component to the commit's parent reproduces all three committed files exactly.

  • Michael Bancksaw an earlier versiontrailerReported looking over the series and Paquier's changes in #44, before the later changes to control-file synchronization.
  • Fabien Coelhosaw the final versiontrailerReviewed the option's risks, tested successive versions, and explicitly reported successful compilation, checks, and documentation build for the final component in #138.
  • Sergei Kornilovsaw an earlier versiontrailerTested the original series in #46 and read its update in #49, before --no-sync was extended to control-file synchronization.
Add options to enable and disable checksums in pg_checksums
22 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1331 of 3 reviewers saw the final version

Commits the enable/disable component of #133, leaving --no-sync separate; differences are documentation, comments, and making a write-error message translatable. The commit credits Banck and Paquier, consistent with #1 and #45.

  • Fabien Coelhosaw the final versiontrailerRepeatedly tested and reviewed the feature, secured the data-before-control synchronization order, and identified the final translation and documentation issues in #138.
  • Magnus Hagandersaw an earlier versiontrailerReviewed default behavior and concurrency risks, proposed renaming pg_control in #84, and assessed that implementation in #96 before it was removed.
  • Sergei Kornilovsaw an earlier versiontrailerTested the series and raised version, replication, and block-size issues in #46, #49, and #65, before the final synchronization changes.
Refactor more code logic to update the control file
18 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #1041 of 1 reviewer saw the final version

Uses the five-file refactor in #104, replacing the flag mask with bool do_sync and correcting pg_resetwal's path, backend close-error handling, and pg_rewind's --no-sync behavior, as enumerated in #107.

  • Michael Paquiersaw the final versiontrailerReviewed both versions, proposed the expanded shared API, fixed correctness issues, and committed the result as reported in #107.
Rename pg_verify_checksums to pg_checksums
13 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #473 of 3 reviewers saw the final version

Commits only the rename component of #47, updating documentation, build files, tests, and program references; applying that component to the parent reproduces the committed files exactly.

  • Michael Bancksaw the final versiontrailerReported examining the split series in #44, after which the rename received only light documentation and header changes.
  • Fabien Coelhosaw the final versiontrailerReported successful rename application, compilation, checks, and documentation build in #53, while discussing documentation links and SGML alignment.
  • Seigei Kornilovsaw the final versiontrailerThe credited name refers to Sergei Kornilov, who reviewed documentation identifiers and markup in #46 and read the updated series in #49.
Fix cross-version compatibility checks of pg_verify_checksums
13 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+2 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #471 of 1 reviewer saw the final version

Commits the seven-line control-file version-check component of #47 exactly, independently of the other three patches; its stable-branch backport is the same change.

  • Sergei Kornilovsaw the final versiontrailerAfter reporting the missing compatibility check in #46, read the corrected series and asked about documenting the restriction in #49.
Add routine able to update the control file to src/common/
12 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #432 of 2 reviewers saw the final version

Extracts the shared-control-file component of #43, with only a function-comment edit documenting ControlFileLock responsibility. Its Banck/Paquier authorship follows the extraction in #40 and Paquier's backend-aware revision.

  • Fabien Coelhosaw the final versiontrailerTested the earlier refactor in #41 and explicitly reported successful application, compilation, and checks for the separated refactor in #53, after its commit.
  • Sergei Kornilovsaw the final versiontrailerReported successful installcheck-world and feature testing for the complete series in #46, before the helper landed with only comment edits.

Credits across 7 commits

Author
Michael Paquier5
Fabien COELHO2
Michael Banck2
Reviewer
Sergei Kornilov5
Fabien COELHO4
Michael Banck2
Michael Paquiercommitter2
Magnus Hagander1
Reported by
Sergei Kornilov1
Committer
Michael Paquier7