Jan 2019

3 commits
isolationtester: Use atexit()
7 Jan 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The isolationtester patch in #4 matches the committed diff in src/test/isolation/isolationtester.c, including disconnect_atexit(), callback registration, and replacement of exit_nicely() calls.

  • Alvaro Herrerasaw the final versiontrailerIn #5, he reported a quick visual review of the isolationtester addition in #4.
initdb: Use atexit()
7 Jan 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #41 of 2 reviewers saw the final version

The committed src/bin/initdb/initdb.c diff exactly matches the initdb patch in #4, including the success flag and cleanup_directories_atexit(). The commit description adds an explanation that the pattern mirrors pg_basebackup.

  • Alvaro Herrerasaw the final versiontrailerHe commented on the original cleanup approach in #2 and approved the revised success-flag approach in #5.
  • Michael Paquiersaw an earlier versiontrailerIn #3, he criticized resetting all cleanup flags in #1, after which #4 changed the cleanup logic to use a success flag.
pg_basebackup: Use atexit()
7 Jan 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #41 of 2 reviewers saw the final version

The pg_basebackup patch in #4 matches the committed changes in src/bin/pg_basebackup/pg_basebackup.c, pg_receivewal.c, and pg_recvlogical.c without code edits.

  • Alvaro Herrerasaw the final versiontrailerHe identified duplicate callback registration in #2 and followed up on the corrected series with approval in #5.
  • Michael Paquierno review foundtrailerHis only review message, #3, addresses initdb cleanup flags and provides no identifiable review of the pg_basebackup changes.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Alvaro Herrera3
Michael Paquier2
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.