Install JIT headers

Hi,

On 2019-01-22 11:08:40 -0800, Donald Dong wrote:

In the standard_planner, we set the proper JIT flags on the resulting
PlannedStmt node. We also offered a planer hook so extensions can
add customized planners. The JIT flags in jit/jit.h however, is
not present on the system. I think it's probably better to
install the jit headers?

diff --git a/src/include/Makefile b/src/include/Makefile
index 6bdfd7db91..041702809e 100644
--- a/src/include/Makefile
+++ b/src/include/Makefile
@@ -19,7 +19,7 @@ all: pg_config.h pg_config_ext.h pg_config_os.h
# Subdirectories containing installable headers
SUBDIRS = access bootstrap catalog commands common datatype \
executor fe_utils foreign \
-       lib libpq mb nodes optimizer parser partitioning postmaster \
+       jit lib libpq mb nodes optimizer parser partitioning postmaster \
regex replication rewrite \
statistics storage tcop snowball snowball/libstemmer tsearch \
tsearch/dicts utils port port/atomics port/win32 port/win32_msvc \

Seems like a good idea. I think we ought to backpatch that to 11? Will
do tomorrow if nobody protests.

Greetings,

Andres Freund

On Tue, Jan 22, 2019 at 11:42:35AM -0800, Andres Freund wrote:

Hi,

On 2019-01-22 11:08:40 -0800, Donald Dong wrote:

In the standard_planner, we set the proper JIT flags on the resulting
PlannedStmt node. We also offered a planer hook so extensions can
add customized planners. The JIT flags in jit/jit.h however, is
not present on the system. I think it's probably better to
install the jit headers?

diff --git a/src/include/Makefile b/src/include/Makefile
index 6bdfd7db91..041702809e 100644
--- a/src/include/Makefile
+++ b/src/include/Makefile
@@ -19,7 +19,7 @@ all: pg_config.h pg_config_ext.h pg_config_os.h
# Subdirectories containing installable headers
SUBDIRS = access bootstrap catalog commands common datatype \
executor fe_utils foreign \
-       lib libpq mb nodes optimizer parser partitioning postmaster \
+       jit lib libpq mb nodes optimizer parser partitioning postmaster \
regex replication rewrite \
statistics storage tcop snowball snowball/libstemmer tsearch \
tsearch/dicts utils port port/atomics port/win32 port/win32_msvc \

Seems like a good idea. I think we ought to backpatch that to 11? Will
do tomorrow if nobody protests.

+1 for back-patching

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

On 2019-01-22 11:42:35 -0800, Andres Freund wrote:

Hi,

On 2019-01-22 11:08:40 -0800, Donald Dong wrote:

In the standard_planner, we set the proper JIT flags on the resulting
PlannedStmt node. We also offered a planer hook so extensions can
add customized planners. The JIT flags in jit/jit.h however, is
not present on the system. I think it's probably better to
install the jit headers?

diff --git a/src/include/Makefile b/src/include/Makefile
index 6bdfd7db91..041702809e 100644
--- a/src/include/Makefile
+++ b/src/include/Makefile
@@ -19,7 +19,7 @@ all: pg_config.h pg_config_ext.h pg_config_os.h
# Subdirectories containing installable headers
SUBDIRS = access bootstrap catalog commands common datatype \
executor fe_utils foreign \
-       lib libpq mb nodes optimizer parser partitioning postmaster \
+       jit lib libpq mb nodes optimizer parser partitioning postmaster \
regex replication rewrite \
statistics storage tcop snowball snowball/libstemmer tsearch \
tsearch/dicts utils port port/atomics port/win32 port/win32_msvc \

Seems like a good idea. I think we ought to backpatch that to 11? Will
do tomorrow if nobody protests.

Pushed to both. Thanks for the patch!

Thanks to Bruce for reminding me of the patch, too.

Greetings,

Andres Freund