model-writtenrun 9715 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andres Freund discovered while working on trigger slotification that heap_getattr() ignored fast defaults, unlike tuple deformation, and questioned the special tuple expansion in GetTupleForTrigger() #1.
- Andres posted a proof of concept routing missing attributes through getmissingattr(), demonstrated that trigger tuple expansion became unnecessary, and requested a broader review of fast defaults; he then traced the expansion to an earlier trigger fix #2 #3.
- Andres identified incorrect HOT-update decisions when a fast-default column was set to NULL and supplied a reproducer in which sequential and index scans returned different results #4 #5.
- Andrew Dunstan agreed to try to organize the broader review, and Andres posted a polished patch removing the trigger workaround and adding the HOT-update reproducer as a regression test #6 #7.
- Alvaro Herrera questioned the exported getmissingattr() name and its behavior for attribute numbers beyond the tuple descriptor #8.
- Andres committed the revised patch with macro-argument parentheses and commit-message clarification, then announced that it had been pushed to master and PostgreSQL 11 #7 171e0418b0 #9.
- After the commit, Andrew Gierth warned that removing trigger tuple expansion could break existing C extensions because heap_getattr() is a compiled-in macro; Andres initially questioned restoring it, while Christoph Berg discussed rebuilding affected packages and asked about compatibility with older servers #10 #11 #12.
- Andres defended the function name and declined a bounds-handling change, arguing that descriptor-boundary problems already existed and that slot_getattr() already used getmissingattr() #13.
- The thread ended with Andres reporting that he had restored tuple expansion for PostgreSQL 11 and planned to warn packagers that newly compiled extensions could require the newly exported getmissingattr() symbol and therefore fail against older servers #14.