Feb 2019

2 commits
Align better test output regex with grammar in pg_dump TAP tests
7 Feb 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #122 of 2 reviewers saw the final version

The commit retains all 20 regex replacements from #12 and adds three equivalent replacements for two CREATE DATABASE patterns and DROP ROLE in src/bin/pg_dump/t/002_pg_dump.pl. Michael Paquier describes these additions in #16.

  • David G. Johnstonsaw the final versiontrailerIn #8, he examined the existing OWNER TO matching behavior discussed around #6, explaining that .* accepts an empty owner and .+ requires a character; the subsequent implementation consists of light regex test changes.
  • Michael Paquiersaw the final versiontrailerHe checked the COMMENT ON behavior in #14, then inspected similar patterns, extended the patch, and committed it as reported in #16.
Tighten some regexes with proper character escaping in pg_dump TAP tests
6 Feb 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #62 of 2 reviewers saw the final version

The commit preserves all 29 regex changes from #6, adding explicit closing \E markers to 19 quoted patterns in src/bin/pg_dump/t/002_pg_dump.pl. These consistency edits were requested in #9, and completion was reported in #11.

  • Daniel Gustafssonsaw the final versiontrailerHe reviewed #1 in #2 and identified the additional empty-owner matching issue; only light quoting changes followed for this commit.
  • Michael Paquiersaw the final versiontrailerHe investigated escaping coverage, proposed literal quoting in #5, requested closing markers in #9, and confirmed committing after checking the whole set in #11.

Credits across 2 commits

Author
Daniel Gustafsson1
David Rowley1
Reviewer
Michael Paquier2
Daniel Gustafsson1
David G. Johnston1
Committer
Michael Paquier2