obsolete comment above index_pages_fetched
Started by Amit Langotealmost 7 years ago3 messages
Hi,
I think the following commit:
commit c6e4133fae1fde93769197379ffcc2b379845113
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed Nov 7 12:12:56 2018 -0500
Postpone calculating total_table_pages until after pruning/exclusion.
...
obsoleted a sentence in the comment above index_pages_fetched(), which says:
* "index_pages" is the amount to add to the total table space, which was
* computed for us by query_planner.
total_table_pages is computed by make_one_rel as of the aforementioned
commit. Attached fixes this.
Thanks,
Amit
Attachments:
index_pages_fetched-comment-fix.patchtext/plain; charset=UTF-8; name=index_pages_fetched-comment-fix.patchDownload
diff --git a/src/backend/optimizer/path/costsize.c b/src/backend/optimizer/path/costsize.c
index beee50ec13..4b9be13f08 100644
--- a/src/backend/optimizer/path/costsize.c
+++ b/src/backend/optimizer/path/costsize.c
@@ -815,7 +815,7 @@ extract_nonindex_conditions(List *qual_clauses, List *indexclauses)
* product rather than calculating it here. "pages" is the number of pages
* in the object under consideration (either an index or a table).
* "index_pages" is the amount to add to the total table space, which was
- * computed for us by query_planner.
+ * computed for us by make_one_rel.
*
* Caller is expected to have ensured that tuples_fetched is greater than zero
* and rounded to integer (see clamp_row_est). The result will likewise be
Re: obsolete comment above index_pages_fetched
On Wed, Feb 13, 2019 at 01:57:09PM +0900, Amit Langote wrote:
total_table_pages is computed by make_one_rel as of the aforementioned
commit. Attached fixes this.
Thanks, fixed.
--
Michael