obsolete comment above index_pages_fetched

Started by Amit Langoteabout 7 years ago3 messageshackers
Jump to latest
#1Amit Langote
Langote_Amit_f8@lab.ntt.co.jp

Hi,

I think the following commit:

commit c6e4133fae1fde93769197379ffcc2b379845113
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed Nov 7 12:12:56 2018 -0500

Postpone calculating total_table_pages until after pruning/exclusion.
...

obsoleted a sentence in the comment above index_pages_fetched(), which says:

* "index_pages" is the amount to add to the total table space, which was
* computed for us by query_planner.

total_table_pages is computed by make_one_rel as of the aforementioned
commit. Attached fixes this.

Thanks,
Amit

Attachments:

index_pages_fetched-comment-fix.patchtext/plain; charset=UTF-8; name=index_pages_fetched-comment-fix.patchDownload+1-1
#2Michael Paquier
michael@paquier.xyz
In reply to: Amit Langote (#1)
Re: obsolete comment above index_pages_fetched

On Wed, Feb 13, 2019 at 01:57:09PM +0900, Amit Langote wrote:

total_table_pages is computed by make_one_rel as of the aforementioned
commit. Attached fixes this.

Thanks, fixed.
--
Michael

#3Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
In reply to: Michael Paquier (#2)
Re: obsolete comment above index_pages_fetched

On 2019/02/13 16:33, Michael Paquier wrote:

On Wed, Feb 13, 2019 at 01:57:09PM +0900, Amit Langote wrote:

total_table_pages is computed by make_one_rel as of the aforementioned
commit. Attached fixes this.

Thanks, fixed.

Thank you.

Regards,
Amit