Removal of duplicate variable declarations in fe-connect.c
Hi Hackers,
During the development of another feature, I found that same local
variables are declared twice.
IMO, there is no need of again declaring the local variables. Patch
attached.
Regards,
Haribabu Kommi
Fujitsu Australia
Attachments:
0001-Removal-of-duplicate-local-variable-declaration.patchapplication/octet-stream; name=0001-Removal-of-duplicate-local-variable-declaration.patchDownload+0-4
On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
During the development of another feature, I found that same local
variables are declared twice.
IMO, there is no need of again declaring the local variables. Patch
attached.
Indeed, fixed. That's not a good practice, and each variable is
assigned in its own block before getting used, so there is no
overlap.
--
Michael
On Fri, Feb 22, 2019 at 3:22 PM Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
During the development of another feature, I found that same local
variables are declared twice.
IMO, there is no need of again declaring the local variables. Patch
attached.Indeed, fixed. That's not a good practice, and each variable is
assigned in its own block before getting used, so there is no
overlap.
Thanks.
Regards,
Haribabu Kommi
Fujitsu Australia