Feb 2019

4 commits
Merge near-duplicate code in RI triggers
28 Feb 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% suremodified before commitlight changesfrom patchset #31 of 1 reviewer saw the final version

The commit implements the ri_set() consolidation from #3 in src/backend/utils/adt/ri_triggers.c, preserving the DEFAULT-only recheck. Beyond tuple-slot rebasing, it renames set_to_null to is_set_null, places the shared function after all four wrappers, and adjusts comments and conditional formatting.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Remove unnecessary unused MATCH PARTIAL code
28 Feb 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The commit matches the complete MATCH PARTIAL cleanup in #1, including centralized validation in ri_FetchConstraintInfo() and simplified update checks. Differences adapt moved code to tuple slots and slot_getsysattr(), which already exist in the commit's parent.

  • Corey Huinkersaw the final versiontrailerCorey examined the cleanup in #2 and #3, identified further SET NULL/DEFAULT duplication, and reported passing make check before the rebased patch landed.
Reduce comments
28 Feb 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The complete comment-reduction patch from #1 matches the commit's 379 added and removed lines after whitespace normalization and the rebase-required new_row-to-new_slot substitution.

  • Corey Huinkersaw the final versiontrailerCorey reported examining the cleanup more closely and passing make check in #3, with only rebasing following for this patch.
Compact for loops
28 Feb 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The complete loop-compaction patch from #1 matches the commit: all 47 whitespace-normalized added and removed lines in src/backend/utils/adt/ri_triggers.c are identical.

  • Corey Huinkersaw the final versiontrailerCorey reported closer examination and a passing make check with his extension in #3, and the committed loop patch retains the reviewed changes.

Credits across 4 commits

Author
Peter EisentrautLLM3
Corey Huinker1
Reviewer
Corey Huinker3
Peter Eisentrautcommitter1
Committer
Peter Eisentraut4

N LLM means N of the credits come from LLM analysis, not from commit trailers.