Mar 2019

1 commit
Tighten use of OpenTransientFile and CloseTransientFile
8 Mar 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 moreAlso in: get_controlfile() can leak fds in the backend (not this thread)
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #60 of 3 reviewers saw the final version

The commit retains all 17 files and changes from #6, with formatting, a diagnostic newline, the corrected tmppath diagnostic in SaveSlotToPath(), and ERROR changed to FATAL in src/backend/utils/cache/relmapper.c. This matching submission postdates both patchsets listed for thread #40197, which supplied earlier context rather than the final patch.

  • Álvaro Herrerasaw an earlier versiontrailerIdentified the missing diagnostic newline in #8 while reviewing #6, before the committed ERROR-to-FATAL behavior change.
  • Georgios Kokolatossaw an earlier versiontrailerFound the missing SaveSlotToPath() check in #4 and reported testing and readiness of the second version in #7, before the committed ERROR-to-FATAL behavior change.
  • Joe Conwaysaw an earlier versiontrailerProposed centralizing the patch's repeated error reporting inside CloseTransientFile() in #2, before additional checks and error-severity changes.

Credits across 1 commit

Author
Michael Paquier1
Reviewer
Alvaro Herrera1
Georgios Kokolatos1
Joe Conway1
Reported by
Joe Conway1
Michael Paquier1
Committer
Michael Paquier1