model-writtenrun 9646 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Michael Paquier opened the thread with a patch to use read-only transient-file opens where sufficient and report previously unchecked close failures, choosing error levels consistent with surrounding code after Joe Conway's related report #1.
- Joe Conway proposed extending CloseTransientFile() to centralize error reporting #2, but Michael preferred preserving its close()-like interface because callers sometimes lack filenames #3, and Robert Haas questioned the proposed interface's savings and flexibility #5.
- Georgios Kokolatos identified a missing SaveSlotToPath() check #4; Michael's revision added replication-slot close checks, changed replication-origin errors to PANIC, and corrected the shared-memory diagnostic #6.
- Georgios marked the second version ready for a committer while recording a failed installcheck-world run without details #7, and Alvaro Herrera identified a missing diagnostic newline that Michael acknowledged #8 #9.
- Michael committed #6 as 82a5649fb9, adding the newline, formatting adjustments, a corrected temporary-file diagnostic, and a FATAL error level for relation-map close failures, then announced completion #10.
- Months later, Andres Freund challenged the descriptor-leak rationale, the usefulness of ERROR, and the incomplete coverage of other close() calls #11; Michael defended making failures visible and matching neighboring error levels, while acknowledging that other callers deserved investigation #12, leaving the change committed with no follow-up patch or revert shown.