[PATCH] remove repetitive characters in fdwhandler.sgml

Started by Zhang, Jiealmost 7 years ago6 messages

Zhang, Jie

zhangjie2@cn.fujitsu.com

almost 7 years ago

1 attachment(s)

Hi all,

Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml.

Page: https://github.com/postgres/postgres/blob/master/doc/src/sgml/fdwhandler.sgml

---------------------------------------------------------------------------
<para>
This function should store the tuple into the provided, or clear it if if★ The characters [if] is repeated.
the row lock couldn't be obtained. The row lock type to acquire is
defined by <literal>erm->markType</literal>, which is the value
previously returned by <function>GetForeignRowMarkType</function>.
(<literal>ROW_MARK_REFERENCE</literal> means to just re-fetch the tuple
without acquiring any lock, and <literal>ROW_MARK_COPY</literal> will
never be seen by this routine.)
</para>
----------------------------------------------------------------------------

Best Regards!

Attachments:

fdwhandler_sgml.patchapplication/octet-stream; name=fdwhandler_sgml.patchDownload

diff --git a/doc/src/sgml/fdwhandler.sgml b/doc/src/sgml/fdwhandler.sgml
index 81c12e3..b66b9d4 100644
--- a/doc/src/sgml/fdwhandler.sgml
+++ b/doc/src/sgml/fdwhandler.sgml
@@ -1010,7 +1010,7 @@ RefetchForeignRow(EState *estate,
     </para>
 
     <para>
-     This function should store the tuple into the provided, or clear it if if
+     This function should store the tuple into the provided, or clear it if
      the row lock couldn't be obtained.  The row lock type to acquire is
      defined by <literal>erm-&gt;markType</literal>, which is the value
      previously returned by <function>GetForeignRowMarkType</function>.

Michael Paquier

michael@paquier.xyz

almost 7 years ago

In reply to: Zhang, Jie (#1)

Re: [PATCH] remove repetitive characters in fdwhandler.sgml

On Tue, Mar 12, 2019 at 01:37:04AM +0000, Zhang, Jie wrote:

Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml.

     <para>
-     This function should store the tuple into the provided, or clear it if if
+     This function should store the tuple into the provided, or clear it if
      the row lock couldn't be obtained.  The row lock type to acquire is

The typo is clear, however the formulation of the full sentence is
confusing. This function should store the tuple into the provided
slot, no?
--
Michael

Zhang, Jie

zhangjie2@cn.fujitsu.com

almost 7 years ago

In reply to: Michael Paquier (#2)

RE: [PATCH] remove repetitive characters in fdwhandler.sgml

This function should store the tuple into the provided slot, no?

Yes, this modification is easier to understand.

-----Original Message-----
From: Michael Paquier [mailto:michael@paquier.xyz]
Sent: Wednesday, March 13, 2019 1:02 PM
To: Zhang, Jie/张杰 <zhangjie2@cn.fujitsu.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] remove repetitive characters in fdwhandler.sgml

On Tue, Mar 12, 2019 at 01:37:04AM +0000, Zhang, Jie wrote:

Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml.

     <para>
-     This function should store the tuple into the provided, or clear it if if
+     This function should store the tuple into the provided, or clear 
+ it if
      the row lock couldn't be obtained.  The row lock type to acquire is

The typo is clear, however the formulation of the full sentence is confusing. This function should store the tuple into the provided slot, no?
--
Michael

Etsuro Fujita

fujita.etsuro@lab.ntt.co.jp

almost 7 years ago

In reply to: Michael Paquier (#2)

Re: [PATCH] remove repetitive characters in fdwhandler.sgml

(2019/03/13 14:02), Michael Paquier wrote:

On Tue, Mar 12, 2019 at 01:37:04AM +0000, Zhang, Jie wrote:

Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml.
<para>
-     This function should store the tuple into the provided, or clear it if if
+     This function should store the tuple into the provided, or clear it if
the row lock couldn't be obtained.  The row lock type to acquire is
The typo is clear, however the formulation of the full sentence is
confusing. This function should store the tuple into the provided
slot, no?

Yeah, I think so too.

Best regards,
Etsuro Fujita

Andres Freund

andres@anarazel.de

almost 7 years ago

In reply to: Etsuro Fujita (#4)

Re: [PATCH] remove repetitive characters in fdwhandler.sgml

On 2019-03-13 14:55:59 +0900, Etsuro Fujita wrote:

(2019/03/13 14:02), Michael Paquier wrote:
On Tue, Mar 12, 2019 at 01:37:04AM +0000, Zhang, Jie wrote:

Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml.
<para>
-     This function should store the tuple into the provided, or clear it if if
+     This function should store the tuple into the provided, or clear it if
the row lock couldn't be obtained.  The row lock type to acquire is
The typo is clear, however the formulation of the full sentence is
confusing. This function should store the tuple into the provided
slot, no?
Yeah, I think so too.

Sorry for that, I'll fix the sentence tomorrow. Andres vs Grammar: 3 :
3305.

Greetings,

Andres Freund

andres@anarazel.de

almost 7 years ago

In reply to: Andres Freund (#5)

Re: [PATCH] remove repetitive characters in fdwhandler.sgml

On 2019-03-12 23:19:23 -0700, Andres Freund wrote:

On 2019-03-13 14:55:59 +0900, Etsuro Fujita wrote:
(2019/03/13 14:02), Michael Paquier wrote:
On Tue, Mar 12, 2019 at 01:37:04AM +0000, Zhang, Jie wrote:

Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml.
<para>
-     This function should store the tuple into the provided, or clear it if if
+     This function should store the tuple into the provided, or clear it if
the row lock couldn't be obtained.  The row lock type to acquire is
The typo is clear, however the formulation of the full sentence is
confusing. This function should store the tuple into the provided
slot, no?
Yeah, I think so too.
Sorry for that, I'll fix the sentence tomorrow. Andres vs Grammar: 3 :
3305.

And pushed. Thanks for the report!