Fix typo in test code comments
Hi,
I think ts_vector is a typo for tsvector.
regards,
Sho Kato
Attachments:
fix-typo-for-tsvector.patchapplication/octet-stream; name=fix-typo-for-tsvector.patchDownload+4-0
Hello.
At Fri, 15 Mar 2019 04:37:03 +0000, "Kato, Sho" <kato-sho@jp.fujitsu.com> wrote in <25C1C6B2E7BE044889E4FE8643A58BA963E1D03D@G01JPEXMBKW03>
Hi,
I think ts_vector is a typo for tsvector.
--- ts_vector corner cases +-- tsvector corner cases select to_tsvector('""'::json);
Yeah, surely it is typo, but not for tsvector but
to_tsvector. See the block just below.
-- json_to_tsvector corner cases
select json_to_tsvector('""'::json, '"all"');
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Friday, March 15, 2019 2:24 PM, Kyotaro HORIGUCHI wrote
Yeah, surely it is typo, but not for tsvector but to_tsvector. See the
block just below.-- json_to_tsvector corner cases
select json_to_tsvector('""'::json, '"all"');
Oops, thank you for your advice.
I fixed it.
Regards,
Sho Kato
Show quoted text
-----Original Message-----
From: Kyotaro HORIGUCHI [mailto:horiguchi.kyotaro@lab.ntt.co.jp]
Sent: Friday, March 15, 2019 2:24 PM
To: Kato, Sho/加藤 翔 <kato-sho@jp.fujitsu.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix typo in test code commentsHello.
At Fri, 15 Mar 2019 04:37:03 +0000, "Kato, Sho" <kato-sho@jp.fujitsu.com>
wrote in <25C1C6B2E7BE044889E4FE8643A58BA963E1D03D@G01JPEXMBKW03>Hi,
I think ts_vector is a typo for tsvector.
--- ts_vector corner cases +-- tsvector corner cases select to_tsvector('""'::json);Yeah, surely it is typo, but not for tsvector but to_tsvector. See the
block just below.-- json_to_tsvector corner cases
select json_to_tsvector('""'::json, '"all"');regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
fix-typo-for-tsvector-v2.patchapplication/octet-stream; name=fix-typo-for-tsvector-v2.patchDownload+4-0
On Fri, Mar 15, 2019 at 02:24:29PM +0900, Kyotaro HORIGUCHI wrote:
Yeah, surely it is typo, but not for tsvector but
to_tsvector. See the block just below.
Yes, I agree with Horiguchi-san here that this refers to the function
call, and not the data type. Everybody agrees?
--
Michael
On Fri, Mar 15, 2019 at 05:49:47AM +0000, Kato, Sho wrote:
Oops, thank you for your advice.
I fixed it.
Committed.
--
Michael
Committed.
Thanks!
Regards,
sho kato
Show quoted text
-----Original Message-----
From: Michael Paquier [mailto:michael@paquier.xyz]
Sent: Friday, March 15, 2019 4:24 PM
To: Kato, Sho/加藤 翔 <kato-sho@jp.fujitsu.com>
Cc: 'Kyotaro HORIGUCHI' <horiguchi.kyotaro@lab.ntt.co.jp>;
pgsql-hackers@postgresql.org
Subject: Re: Fix typo in test code commentsOn Fri, Mar 15, 2019 at 05:49:47AM +0000, Kato, Sho wrote:
Oops, thank you for your advice.
I fixed it.Committed.
--
Michael