Fix typo in test code comments

Started by Kato, Shoalmost 7 years ago6 messages

Kato, Sho

kato-sho@jp.fujitsu.com

almost 7 years ago

1 attachment(s)

Hi,

I think ts_vector is a typo for tsvector.

regards,
Sho Kato

Attachments:

fix-typo-for-tsvector.patchapplication/octet-stream; name=fix-typo-for-tsvector.patchDownload

diff --git a/src/test/regress/expected/json.out b/src/test/regress/expected/json.out
index 66d10ae30d..88f0f91096 100644
--- a/src/test/regress/expected/json.out
+++ b/src/test/regress/expected/json.out
@@ -2427,7 +2427,7 @@ select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d":
  '123':5 '456':7 'aaa':1 'bbb':3
 (1 row)
 
--- ts_vector corner cases
+-- tsvector corner cases
 select to_tsvector('""'::json);
  to_tsvector 
 -------------
diff --git a/src/test/regress/expected/jsonb.out b/src/test/regress/expected/jsonb.out
index 8dcdaf5602..0fc6580884 100644
--- a/src/test/regress/expected/jsonb.out
+++ b/src/test/regress/expected/jsonb.out
@@ -4225,7 +4225,7 @@ select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d"
  '123':5 '456':7 'aaa':1 'bbb':3
 (1 row)
 
--- ts_vector corner cases
+-- tsvector corner cases
 select to_tsvector('""'::jsonb);
  to_tsvector 
 -------------
diff --git a/src/test/regress/sql/json.sql b/src/test/regress/sql/json.sql
index d1e4008427..d9340c0946 100644
--- a/src/test/regress/sql/json.sql
+++ b/src/test/regress/sql/json.sql
@@ -788,7 +788,7 @@ select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d":
 select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::json, '"boolean"');
 select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::json, '["string", "numeric"]');
 
--- ts_vector corner cases
+-- tsvector corner cases
 select to_tsvector('""'::json);
 select to_tsvector('{}'::json);
 select to_tsvector('[]'::json);
diff --git a/src/test/regress/sql/jsonb.sql b/src/test/regress/sql/jsonb.sql
index 6cbdfe4395..a93cfb395d 100644
--- a/src/test/regress/sql/jsonb.sql
+++ b/src/test/regress/sql/jsonb.sql
@@ -1114,7 +1114,7 @@ select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d"
 select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::jsonb, '"boolean"');
 select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::jsonb, '["string", "numeric"]');
 
--- ts_vector corner cases
+-- tsvector corner cases
 select to_tsvector('""'::jsonb);
 select to_tsvector('{}'::jsonb);
 select to_tsvector('[]'::jsonb);

Kyotaro HORIGUCHI

horiguchi.kyotaro@lab.ntt.co.jp

almost 7 years ago

In reply to: Kato, Sho (#1)

Re: Fix typo in test code comments

Hello.

At Fri, 15 Mar 2019 04:37:03 +0000, "Kato, Sho" <kato-sho@jp.fujitsu.com> wrote in <25C1C6B2E7BE044889E4FE8643A58BA963E1D03D@G01JPEXMBKW03>

Hi,

I think ts_vector is a typo for tsvector.

--- ts_vector corner cases
+-- tsvector corner cases
select to_tsvector('""'::json);

Yeah, surely it is typo, but not for tsvector but
to_tsvector. See the block just below.

-- json_to_tsvector corner cases
select json_to_tsvector('""'::json, '"all"');

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Kato, Sho

kato-sho@jp.fujitsu.com

almost 7 years ago

In reply to: Kyotaro HORIGUCHI (#2)

1 attachment(s)

RE: Fix typo in test code comments

At Friday, March 15, 2019 2:24 PM, Kyotaro HORIGUCHI wrote

Yeah, surely it is typo, but not for tsvector but to_tsvector. See the
block just below.

-- json_to_tsvector corner cases
select json_to_tsvector('""'::json, '"all"');

Oops, thank you for your advice.
I fixed it.

Regards,
Sho Kato

Show quoted text

-----Original Message-----
From: Kyotaro HORIGUCHI [mailto:horiguchi.kyotaro@lab.ntt.co.jp]
Sent: Friday, March 15, 2019 2:24 PM
To: Kato, Sho/加藤翔 <kato-sho@jp.fujitsu.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix typo in test code comments

Hello.

At Fri, 15 Mar 2019 04:37:03 +0000, "Kato, Sho" <kato-sho@jp.fujitsu.com>
wrote in <25C1C6B2E7BE044889E4FE8643A58BA963E1D03D@G01JPEXMBKW03>

Hi,

I think ts_vector is a typo for tsvector.
--- ts_vector corner cases
+-- tsvector corner cases
select to_tsvector('""'::json);
Yeah, surely it is typo, but not for tsvector but to_tsvector. See the
block just below.

-- json_to_tsvector corner cases
select json_to_tsvector('""'::json, '"all"');

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

fix-typo-for-tsvector-v2.patchapplication/octet-stream; name=fix-typo-for-tsvector-v2.patchDownload

diff --git a/src/test/regress/expected/json.out b/src/test/regress/expected/json.out
index 66d10ae30d..cb93598039 100644
--- a/src/test/regress/expected/json.out
+++ b/src/test/regress/expected/json.out
@@ -2427,7 +2427,7 @@ select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d":
  '123':5 '456':7 'aaa':1 'bbb':3
 (1 row)
 
--- ts_vector corner cases
+-- to_tsvector corner cases
 select to_tsvector('""'::json);
  to_tsvector 
 -------------
diff --git a/src/test/regress/expected/jsonb.out b/src/test/regress/expected/jsonb.out
index 8dcdaf5602..c251eb70be 100644
--- a/src/test/regress/expected/jsonb.out
+++ b/src/test/regress/expected/jsonb.out
@@ -4225,7 +4225,7 @@ select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d"
  '123':5 '456':7 'aaa':1 'bbb':3
 (1 row)
 
--- ts_vector corner cases
+-- to_tsvector corner cases
 select to_tsvector('""'::jsonb);
  to_tsvector 
 -------------
diff --git a/src/test/regress/sql/json.sql b/src/test/regress/sql/json.sql
index d1e4008427..0f0a32e2a0 100644
--- a/src/test/regress/sql/json.sql
+++ b/src/test/regress/sql/json.sql
@@ -788,7 +788,7 @@ select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d":
 select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::json, '"boolean"');
 select json_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::json, '["string", "numeric"]');
 
--- ts_vector corner cases
+-- to_tsvector corner cases
 select to_tsvector('""'::json);
 select to_tsvector('{}'::json);
 select to_tsvector('[]'::json);
diff --git a/src/test/regress/sql/jsonb.sql b/src/test/regress/sql/jsonb.sql
index 6cbdfe4395..1bf32076e3 100644
--- a/src/test/regress/sql/jsonb.sql
+++ b/src/test/regress/sql/jsonb.sql
@@ -1114,7 +1114,7 @@ select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d"
 select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::jsonb, '"boolean"');
 select jsonb_to_tsvector('english', '{"a": "aaa in bbb", "b": 123, "c": 456, "d": true, "f": false, "g": null}'::jsonb, '["string", "numeric"]');
 
--- ts_vector corner cases
+-- to_tsvector corner cases
 select to_tsvector('""'::jsonb);
 select to_tsvector('{}'::jsonb);
 select to_tsvector('[]'::jsonb);

Michael Paquier

michael@paquier.xyz

almost 7 years ago

In reply to: Kyotaro HORIGUCHI (#2)

Re: Fix typo in test code comments

On Fri, Mar 15, 2019 at 02:24:29PM +0900, Kyotaro HORIGUCHI wrote:

Yeah, surely it is typo, but not for tsvector but
to_tsvector. See the block just below.

Yes, I agree with Horiguchi-san here that this refers to the function
call, and not the data type. Everybody agrees?
--
Michael

Michael Paquier

michael@paquier.xyz

almost 7 years ago

In reply to: Kato, Sho (#3)

Re: Fix typo in test code comments

On Fri, Mar 15, 2019 at 05:49:47AM +0000, Kato, Sho wrote:

Oops, thank you for your advice.
I fixed it.

Committed.
--
Michael

Kato, Sho

kato-sho@jp.fujitsu.com

almost 7 years ago

In reply to: Michael Paquier (#5)

RE: Fix typo in test code comments

Committed.

Thanks!

Regards,
sho kato

Show quoted text

-----Original Message-----
From: Michael Paquier [mailto:michael@paquier.xyz]
Sent: Friday, March 15, 2019 4:24 PM
To: Kato, Sho/加藤翔 <kato-sho@jp.fujitsu.com>
Cc: 'Kyotaro HORIGUCHI' <horiguchi.kyotaro@lab.ntt.co.jp>;
pgsql-hackers@postgresql.org
Subject: Re: Fix typo in test code comments

On Fri, Mar 15, 2019 at 05:49:47AM +0000, Kato, Sho wrote:

Oops, thank you for your advice.
I fixed it.

Committed.
--
Michael