[PG 9.6]make is failing for test_decoding contrib module.

On Fri, Mar 29, 2019 at 8:24 AM tushar <tushar.ahuja@enterprisedb.com> wrote:

Found by one of the my colleague - Kashif Jeeshan , in PG 9.6 - make is

Kashif Jeeshan?

failing for test_decoding contrib module.

[centos@centos-cpula test_decoding]$ make
gcc -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute
-Wformat-security -fno-strict-aliasing -fwrapv -O2 -fPIC -I. -I.
-I../../src/include -D_GNU_SOURCE -c -o test_decoding.o test_decoding.c
In file included from ../../src/include/postgres.h:48,
from test_decoding.c:13:
../../src/include/utils/elog.h:71:28: error: utils/errcodes.h: No such
file or directory
In file included from ../../src/include/replication/slot.h:15,
from ../../src/include/replication/logical.h:12,
from test_decoding.c:23:
../../src/include/storage/lwlock.h:129:33: error: storage/lwlocknames.h:
No such file or directory
test_decoding.c: In function ‘pg_decode_startup’:
test_decoding.c:127: error: ‘ERRCODE_INVALID_PARAMETER_VALUE’ undeclared
(first use in this function)
test_decoding.c:127: error: (Each undeclared identifier is reported only
once
test_decoding.c:127: error: for each function it appears in.)
make: *** [test_decoding.o] Error 1
[centos@centos-cpula test_decoding]$

I think your tree is not clean, or you haven't built the server
correctly first. If this were actually broken, the buildfarm would be
red:

https://buildfarm.postgresql.org/cgi-bin/show_status.pl

Try 'git clean -dfx'.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 03/29/2019 06:12 PM, Robert Haas wrote:

On Fri, Mar 29, 2019 at 8:24 AM tushar <tushar.ahuja@enterprisedb.com> wrote:

Found by one of the my colleague - Kashif Jeeshan , in PG 9.6 - make is

Kashif Jeeshan?

:-) , actually he is also working  on logical replication on standbys
testing - whenever he has some bandwidth (On/off)  ..he found one issue .
 i suggested him to see the behavior on PG 9.6/ PG 10 and while doing
so - got this issue when he  performed make against test_decoding

test_decoding.c:127: error: for each function it appears in.)
make: *** [test_decoding.o] Error 1
[centos@centos-cpula test_decoding]$

I think your tree is not clean, or you haven't built the server
correctly first. If this were actually broken, the buildfarm would be
red:

https://buildfarm.postgresql.org/cgi-bin/show_status.pl

Try 'git clean -dfx'.

Yes, you are right.

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

On 03/29/2019 06:12 PM, Robert Haas wrote:

Kashif Jeeshan?

Ohh, Please read - Kashif Zeeshan.  Sorry for the typo.

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company