Removing a few more lseek() calls

Started by Thomas Munroover 7 years ago2 messageshackers
Jump to latest
#1Thomas Munro
thomas.munro@gmail.com

Hello,

Patch 0001 gets rid of the unconditional lseek() calls for SLRU I/O,
as a small follow-up to commit c24dcd0c. Patch 0002 gets rid of a few
places that usually do a good job of avoiding lseek() calls while
reading and writing WAL, but it seems better to have no code at all.

--
Thomas Munro
https://enterprisedb.com

Attachments:

0001-Use-pg_pread-and-pg_pwrite-in-slru.c.patchtext/x-patch; charset=US-ASCII; name=0001-Use-pg_pread-and-pg_pwrite-in-slru.c.patchDownload+4-22
0002-Use-pg_pread-and-pg_pwrite-in-various-places.patchtext/x-patch; charset=US-ASCII; name=0002-Use-pg_pread-and-pg_pwrite-in-various-places.patchDownload+13-91
#2Ashwin Agrawal
aagrawal@pivotal.io
In reply to: Thomas Munro (#1)
Re: Removing a few more lseek() calls

On Sat, Mar 30, 2019 at 2:14 AM Thomas Munro <thomas.munro@gmail.com> wrote:

Hello,

Patch 0001 gets rid of the unconditional lseek() calls for SLRU I/O,
as a small follow-up to commit c24dcd0c. Patch 0002 gets rid of a few
places that usually do a good job of avoiding lseek() calls while
reading and writing WAL, but it seems better to have no code at all.

I reviewed the changes and they look good to me. Code looks much cleaner
after 2nd patch.
After these changes, only one usage of SLRU_SEEK_FAILED remains in
SimpleLruDoesPhysicalPageExist().