Minor fix in reloptions.c comments
Hi,
I found some minor grammar mistake while reading reloptions.c code comments.
Attached is the fix.
I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
- * values has no affect until the ...
+ * values has no effect until the ...
Regards,
Kirk Jamison
Attachments:
reloptions-comment-fix.patchapplication/octet-stream; name=reloptions-comment-fix.patchDownload
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
index da66faf..cfbabb5 100644
--- a/src/backend/access/common/reloptions.c
+++ b/src/backend/access/common/reloptions.c
@@ -77,7 +77,7 @@
* n_distinct options can be set at ShareUpdateExclusiveLock because they
* are only used during ANALYZE, which uses a ShareUpdateExclusiveLock,
* so the ANALYZE will not be affected by in-flight changes. Changing those
- * values has no affect until the next ANALYZE, so no need for stronger lock.
+ * values has no effect until the next ANALYZE, so no need for stronger lock.
*
* Planner-related parameters can be set with ShareUpdateExclusiveLock because
* they only affect planning and not the correctness of the execution. Plans
@@ -93,7 +93,7 @@
* vacuum_truncate can be set at ShareUpdateExclusiveLock because it
* is only used during VACUUM, which uses a ShareUpdateExclusiveLock,
* so the VACUUM will not be affected by in-flight changes. Changing its
- * value has no affect until the next VACUUM, so no need for stronger lock.
+ * value has no effect until the next VACUUM, so no need for stronger lock.
*/
static relopt_bool boolRelOpts[] =
On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
I found some minor grammar mistake while reading reloptions.c code comments.
Attached is the fix.
I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
- * values has no affect until the ...
+ * values has no effect until the ...
A lot of those parameter updates affect processing and still they have
many side effects, as per those paragraphs.
Fixed, thanks!
--
Michael
On Fri, Apr 12, 2019 at 12:01 AM Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
I found some minor grammar mistake while reading reloptions.c code comments.
Attached is the fix.
I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
- * values has no affect until the ...
+ * values has no effect until the ...A lot of those parameter updates affect processing and still they have
many side effects, as per those paragraphs.
Well, "has no affect" is clearly wrong here, and Kirk's fix is clearly
right. I don't know what your point here is.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company