Apr 2021

1 commit
Remove read_page callback from XLogReader.
8 Apr 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #541 of 5 reviewers saw the final version

Applying both patches from #54 to the commit parent leaves only three differences: corrected prose in xlogreader.c, removal of a debug elog in xlogutils.c and disabling WAL_DEBUG in pg_config_manual.h. The commit credits Kyotaro as author and Heikki for parts of an earlier version; Thomas forwarded the final submission.

  • Antonin Houskasaw an earlier versiontrailerAntonin reviewed naming, dispatch macros and buffer semantics in #2 and #4, before the continuation implementation was replaced.
  • Alvaro Herrerasaw an earlier versiontrailerAlvaro caught the pg_waldump regression in #20 and supported clearer state ownership in #49, before the subsequent input-interface and record-seeking changes.
  • Takashi Menjosaw an earlier versiontrailerTakashi reported a WAL_DEBUG build failure, inconsistent buffer allocation and an unnecessary initializer change in #38, before later API revisions.
  • Andres Freundsaw an earlier versiontrailerAndres questioned the initial complexity in #7 and requested an input-setting helper and removal of unnecessary private-pointer type punning in #48, before those interfaces and XLogFindNextRecord were revised.
  • Thomas Munrosaw the final versiontrailerThomas tested and reformatted the series, identified warnings and a record-positioning error in #53, prepared #54 and committed the final version.

Jan 2020

1 commit
Refactor XLogReadRecord(), adding XLogBeginRead() function.
26 Jan 2020Heikki Linnakangasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #230 of 2 reviewers saw the final version

Applying #23 to the commit parent shows naming/comment edits and a substantive XLogFindNextRecord change: it positions the reader with XLogBeginRead instead of restoring saved pointers. Heikki explicitly describes that final correction in #28.

  • Kyotaro Horiguchisaw an earlier versiontrailerKyotaro endorsed the interface in #25 and reported successful checking with a comment correction in #26, before Heikki changed XLogFindNextRecord's positioning behavior.
  • Alvaro Herrerasaw an earlier versiontrailerAlvaro approved the attached proposal in #24, before the substantive XLogFindNextRecord correction described in #28.

Credits across 2 commits

Author
Heikki Linnakangas1 LLM2
Kyotaro Horiguchi1
Reviewer
Alvaro Herrera2
Andres Freund1
Antonin Houska1
Kyotaro Horiguchi1
Takashi Menjo1
Thomas Munro1
Committer
Heikki Linnakangas1
Thomas Munro1

N LLM means N of the credits come from LLM analysis, not from commit trailers.