Jun 2019

1 commit
Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise)
10 Jun 2019Alvaro Herreramaster12beta2REL_19_STABLE12beta2REL_18_STABLE12beta2REL_17_STABLE12beta2REL_16_STABLE12beta2REL_15_STABLE12beta2REL_14_STABLE12beta2REL_13_STABLE12beta2+3 moreAlso in: pg_dump is broken for partition tablespaces (not this thread)Also in: pg_dump partitions can lead to inconsistent state after restore
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #41 of 1 reviewer saw the final version

The commit combines both patches from #4, adding a binary-upgrade guard against duplicate partition CHECK constraints in src/bin/pg_dump/pg_dump.c, renaming local flags, expanding comments, and removing a redundant ATTACH test. This June submission is later than every listed patchset in thread #40231, while thread #40489 has no patchsets, making this thread the latest matching source.

  • Álvaro Herrerasaw the final versiontrailerAlvaro examined the revised implementation in #4, reported the additional pg10 upgrade-test failure and its correction in #5, and reviewed the final version as committer.

May 2019

1 commit
Revert "Make pg_dump emit ATTACH PARTITION instead of PARTITION OF"
6 May 2019Alvaro Herreramaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+3 morerevert
LLM analysis, 100% surewritten from the discussion, no matching patch

Alvaro announced reverting the broken partition-dumping change before the minor releases in #3, responding to the failures reported in #1 and #2. The commit restores PARTITION OF behavior and its test expectations; neither attached patchset proposes that revert.

Credits across 2 commits

Author
Alvaro Herrera1
David Rowley1
Reviewer
Alvaro Herrera1
Reported by
Rushabh Lathia1
Committer
Alvaro Herrera2