model-writtenrun 9445 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Ashwin Agrawal proposed making table-AM wrapper names match their callbacks, removing redundant relation prefixes, standardizing parameter comments and renaming amapi.h #1.
- Andres Freund supported adding tuple prefixes but defended relation prefixes as distinguishing whole-relation operations, explained the different audiences for wrapper and callback comments, and deferred any amapi.h rename beyond PostgreSQL 12 #2.
- Ashwin pressed for consistent naming and comments #3, while Andres explained that widespread scan renames would increase review churn and disrupt related APIs and external code #4 #6 #8.
- Alvaro Herrera and Tom Lane argued that newly introduced names deserved consideration before release, with Tom opposing changes to existing systable APIs; Robert Haas proposed renaming only the tuple-related wrappers and retaining all three scan names #9 #11 #12.
- Ashwin submitted the agreed renames, including the simple_table helpers, while leaving the scan names unchanged; he separately renewed his request for discussion of comment consistency #13 #14.
- Alvaro questioned retaining and renaming the sparsely used simple_table helpers, but Andres defended them as avoiding duplicated logic for callers and extensions and supporting possible future catalog changes, so they remained in the patch #15 #16.
- Andres committed #13 as 73b8c3bd28 with a rebase and light formatting and comment edits, announcing completion in #17.
- Ashwin acknowledged the commit in the final message #18; the submitted renaming work had landed, while broader comment standardization had received no further resolution after his follow-up #14.