Jan 2020

2 commits
tableam: New callback relation_fetch_toast_slice.
7 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #490 of 2 reviewers saw the final version

The relation_fetch_toast_slice component of #49 matches the commit's five-file implementation; the only substantive textual difference is shortening an inaccurate scan-key comment in src/backend/access/heap/heaptoast.c.

  • Andres Freundsaw an earlier versionLLM analysis, 97% sureAndres reviewed the earlier implementation and advocated a single sliced/non-sliced detoasting callback in #34, after which the implementation was substantially rewritten; the commit also explicitly credits his review.
  • Peter Eisentrautsaw an earlier versionLLM analysis, 94% surePeter reviewed the earlier API restructuring in #30, before its replacement by the callback design, and is explicitly credited in ce242ae154.
tableam: Allow choice of toast AM.
7 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #491 of 1 reviewer saw the final version

The TOAST-AM selection component of #49 has identical added and removed code across heapam_handler.c, toasting.c, and tableam.h; it introduces relation_toast_am and uses it when creating the TOAST table.

  • Andres Freundsaw the final versionLLM analysis, 97% sureAndres reviewed the series containing this callback in #12, its implementation survived the later restructuring essentially unchanged, and 83322e38da explicitly credits him.

Dec 2019

2 commits
Move heap-specific detoasting logic into a separate function.
18 Dec 2019Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #48

The heap_fetch_toast_slice extraction in #48 matches the committed detoast.c changes except that 'No addition condition' and 'chuns' are corrected in one comment, as confirmed by #49.

Code cleanup for toast_fetch_datum and toast_fetch_datum_slice.
17 Dec 2019Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #471 of 1 reviewer saw the final version

The cleanup component of #47 matches the committed additions and deletions in src/backend/access/common/detoast.c, including variable renaming, consolidated chunk checks, and ereport diagnostics.

  • Peter Eisentrautsaw the final versionLLM analysis, 100% surePeter proposed clearer variable names, restoring chunk-count context, and tightening the assertion in #46, all incorporated by #47 without changing the cleanup's architecture.

Oct 2019

1 commit
Rename some toasting functions based on whether they are heap-specific.
4 Oct 2019Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surelanded as postedfrom patchset #234 of 4 reviewers saw the final version

The renaming component of #23 lands unchanged in purpose and code substitutions; differences in toast_delete signatures result from rebasing it ahead of the uncommitted alternative-AM patch, so the speculative-token parameter is absent.

  • Prabhat Sahusaw the final versionLLM analysis, 96% sure2e8b6bfa90 explicitly credits Prabhat as a reviewer under the spelling 'Prabhat Sabu', although his visible testing in #4 predates the renaming component.
  • Thomas Munrosaw the final versionLLM analysis, 98% sure2e8b6bfa90 explicitly credits Thomas as a reviewer, although his visible compiler report in #5 concerns another component.
  • Andres Freundsaw the final versionLLM analysis, 100% sureAndres identified the misleading generic name toast_insert_or_update in #12, prompting the heap-specific rename accepted in #13 and incorporated into the final patch.
  • Alvaro Herrerasaw the final versionLLM analysis, 98% sure2e8b6bfa90 explicitly credits Álvaro Herrera as a reviewer, while his visible review in #16 specifically addresses the file split.

Sep 2019

2 commits
Create an API for inserting and deleting rows in TOAST tables.
6 Sep 2019Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #174 of 4 reviewers saw the final version

The helper-API component of #17 matches the committed additions and deletions, introducing toast_helper.c/h and ToastTupleContext while replacing duplicated logic in heaptoast.c.

  • Prabhat Sahusaw the final versionLLM analysis, 99% surePrabhat tested the helper-containing series across storage modes, updates, replication, and upgrade scenarios in #4, with only light changes to this component afterward.
  • Thomas Munrosaw the final versionLLM analysis, 98% surebd124996ef explicitly credits Thomas as a reviewer, although #5 reports a compiler problem in the separate alternative-AM component.
  • Andres Freundsaw the final versionLLM analysis, 100% sureAndres examined the deduplicated helper logic, conditions, column flags, and comments in #12, and this component remained effectively unchanged through #17.
  • Alvaro Herrerasaw the final versionLLM analysis, 98% surebd124996ef explicitly credits Álvaro Herrera as a reviewer, though his visible detailed review in #16 covers the file split.
Split tuptoaster.c into three separate files.
5 Sep 2019Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #164 of 4 reviewers saw the final version

The committed file split matches #16's additions and deletions across detoast.c, toast_internals.c, heaptoast.c, headers, and include updates; Alvaro forwarded a rebased version of Robert Haas's original patch from #1.

  • Prabhat Sahusaw the final versionLLM analysis, 99% surePrabhat tested the series containing the file split in #4, and subsequent changes to that component were rebasing, formatting, and whitespace cleanup.
  • Thomas Munrosaw the final versionLLM analysis, 98% sure8b94dab066 explicitly credits Thomas as a reviewer, although his visible compiler finding in #5 concerns another component.
  • Andres Freundsaw the final versionLLM analysis, 100% sureAndres reviewed the code movement and identified trailing whitespace in DETOAST_H in #12, which the final submission corrected.
  • Alvaro Herrerasaw the final versionLLM analysis, 100% sureAlvaro checked Robert's code movement, compiled it, ran headerscheck, and supplied the final rebase with the whitespace fix in #16.

Credits across 7 commits

Author
Robert HaasLLM7
Committer
Robert Haas7

N LLM means N of the credits come from LLM analysis, not from commit trailers.