Compile using the Visual Studio 2019

On Tue, 21 May 2019 at 05:46, Juan José Santamaría Flecha
<juanjo.santamaria@gmail.com> wrote:

While trying to setup a test environment under Windows I have managed to build the source using the latest Visual Studio 2019 [1].

It's only been tested in this one environment, Windows 10 x64, but the changes seem tool dependant only.

Thanks for doing work on this. Just to let you know there's already
some work pending to do this in
/messages/by-id/CAJrrPGegJG_gtQBMQffCNBny3i3fpe8QfE0DUkPSQEZf-FoY9w@mail.gmail.com

It's marked in the next commitfest entry in
https://commitfest.postgresql.org/23/2122/

Maybe you could take a look at that and maybe sign up to review it?

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

On Tue, May 21, 2019 at 02:37:10PM +1200, David Rowley wrote:

Maybe you could take a look at that and maybe sign up to review it?

Yes, that would be great. New VS environments are a pain to set up so
any input is welcome.

-       # visual 2017 hasn't changed the nmake version to 15, so still
          using the older version for comparison.
+       # visual 2019 hasn't changed the nmake version to
          15, so still using the older version for comparison.
        if ($major > 14)

I have not checked the other patch and I am pretty sure that you are
doing the same thing. Still, for the notice, this comment update is
incorrect as VS 2017 also marks nmake with version 15.
--
Michael

On Tue, May 21, 2019 at 7:36 AM Michael Paquier <michael@paquier.xyz> wrote:

On Tue, May 21, 2019 at 02:37:10PM +1200, David Rowley wrote:

Maybe you could take a look at that and maybe sign up to review it?

Yes, that would be great. New VS environments are a pain to set up so
any input is welcome.

At some point I did check, but that previous work went unnoticed. Now that
I have a better knowledge about building on Windows I will take a look at
it.

I have not checked the other patch and I am pretty sure that you are
doing the same thing. Still, for the notice, this comment update is
incorrect as VS 2017 also marks nmake with version 15.

I don't want to keep this thread going any further, so I will check the
other patch and see how it goes through this point.

Regards,

Juan José Santamaría Flecha