with oids option not removed in pg_dumpall

Started by Surafel Temesgenalmost 7 years ago5 messageshackers
Jump to latest
#1Surafel Temesgen
surafel3000@gmail.com

Hello,
Commit 578b229718e8f remove oids option from pg_dump but its is
still in pg_dumpall .The attach patch remove it
regards
Surafel

Attachments:

remove-oids-option-pg_dumpall.patchtext/x-patch; charset=US-ASCII; name=remove-oids-option-pg_dumpall.patchDownload+1-21
#2Michael Paquier
michael@paquier.xyz
In reply to: Surafel Temesgen (#1)
Re: with oids option not removed in pg_dumpall

On Tue, May 21, 2019 at 09:31:48AM +0300, Surafel Temesgen wrote:

Commit 578b229718e8f remove oids option from pg_dump but its is
still in pg_dumpall .The attach patch remove it

Good catch. Your cleanup looks correct to me. Andres, perhaps you
would prefer doing the cleanup yourself?
--
Michael

#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: with oids option not removed in pg_dumpall

On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:

Good catch. Your cleanup looks correct to me. Andres, perhaps you
would prefer doing the cleanup yourself?

As I am cleaning up the area for another issue, applied.
--
Michael

#4Surafel Temesgen
surafel3000@gmail.com
In reply to: Michael Paquier (#3)
Re: with oids option not removed in pg_dumpall

Thank you for applying

regards
Surafel

On Thu, May 23, 2019 at 3:43 AM Michael Paquier <michael@paquier.xyz> wrote:

Show quoted text

On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:

Good catch. Your cleanup looks correct to me. Andres, perhaps you
would prefer doing the cleanup yourself?

As I am cleaning up the area for another issue, applied.
--
Michael

#5Andres Freund
andres@anarazel.de
In reply to: Surafel Temesgen (#4)
Re: with oids option not removed in pg_dumpall

Hi,

On 2019-05-23 16:26:38 +0300, Surafel Temesgen wrote:

Thank you for applying

regards
Surafel

On Thu, May 23, 2019 at 3:43 AM Michael Paquier <michael@paquier.xyz> wrote:

On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:

Good catch. Your cleanup looks correct to me. Andres, perhaps you
would prefer doing the cleanup yourself?

As I am cleaning up the area for another issue, applied.

Thanks for finding and applying.

Greetings,

Andres Freund